Skip to content

🌱 Update github.com/containers/image/v5 to v5.34.1 - #1849

Closed
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:update-con
Closed

🌱 Update github.com/containers/image/v5 to v5.34.1#1849
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:update-con

Conversation

@tmshort

@tmshorttmshort commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Add GOFLAGS to controller-gen invocations
This is to deal with gpgme inclusion weirdness

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerMarch 6, 2025 17:01
@netlify

netlifyBot commented Mar 6, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit2b76373
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67d7eff5683b180008b0fb1d
😎 Deploy Previewhttps://deploy-preview-1849--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

camilamacedo86
camilamacedo86 reviewed Mar 6, 2025
View reviewed changes
Comment threadMakefile
$(CONTROLLER_GEN) rbac:roleName=manager-role paths="./internal/catalogd/..." output:rbac:artifacts:config=$(KUSTOMIZE_CATD_RBAC_DIR)
$(CONTROLLER_GEN) webhook paths="./internal/catalogd/..." output:webhook:artifacts:config=$(KUSTOMIZE_CATD_WEBHOOKS_DIR)
GOFLAGS="-tags=$(GO_BUILD_TAGS)" $(CONTROLLER_GEN) rbac:roleName=manager-role paths="./internal/catalogd/..." output:rbac:artifacts:config=$(KUSTOMIZE_CATD_RBAC_DIR)
GOFLAGS="-tags=$(GO_BUILD_TAGS)" $(CONTROLLER_GEN) webhook paths="./internal/catalogd/..." output:webhook:artifacts:config=$(KUSTOMIZE_CATD_WEBHOOKS_DIR)

@camilamacedo86camilamacedo86Mar 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not work :-(
I am proposing we add its support here: kubernetes-sigs/controller-tools#1158 (comment)

But see has no env var or flag that allow us to pass the build tag so far: https://github.com/kubernetes-sigs/controller-tools/blob/main/pkg/loader/loader.go#L373-L379

The best away so far is replace the dep to downgrade it, see: #1846

@tmshorttmshortMar 6, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think downgrade is dangerous, and the best way would be to move things around instead (short of fixing controller-tools)

@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2025
@tmshortPer Goncalves da Silva
Update github.com/containers/image/v5 to v5.34.1
2b76373
Add GOFLAGS to controller-gen invocations
This is to deal with gpgme inclusion weirdness
Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-merge-robotopenshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 17, 2025
@openshift-merge-robot

openshift-merge-robot commented Mar 23, 2025

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joelanford

joelanford commented Apr 2, 2025

Copy link
Copy Markdown
Member

Done in #1892

@tmshort
tmshort deleted the update-con branch June 25, 2025 18:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86camilamacedo86 left review comments

Assignees

No one assigned

Labels

needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort@openshift-merge-robot@joelanford@camilamacedo86