Skip to content

✨ Add named for controller to distinguish components in logs - #1874

Merged
camilamacedo86 merged 1 commit into
operator-framework:mainfrom
camilamacedo86:add-name-controller
Mar 21, 2025
Merged

✨ Add named for controller to distinguish components in logs#1874
camilamacedo86 merged 1 commit into
operator-framework:mainfrom
camilamacedo86:add-name-controller

Conversation

@camilamacedo86

@camilamacedo86camilamacedo86 commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

This change ensures that catalogd and operator-controller components have distinct controller names (e.g., for clustercatalog). It improves metric aggregation and troubleshooting by clarifying which controller is outputting logs, reducing reliance on user-provided context.

It is related to (Motivated by):

This change ensures that catalogd and operator-controller components have distinct controller names (e.g., for clustercatalog). It improves metric aggregation and troubleshooting by clarifying which controller is outputting logs, reducing reliance on user-provided context.
@camilamacedo86
camilamacedo86 requested a review from a team as a code ownerMarch 20, 2025 10:39
@netlify

netlifyBot commented Mar 20, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit4e26023
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67dbf06134d173000826b8de
😎 Deploy Previewhttps://deploy-preview-1874--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Mar 20, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.91%. Comparing base (0c87596) to head (4e26023).
Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
...logd/controllers/core/clustercatalog_controller.go0.00%1 Missing ⚠️
...atalogd/controllers/core/pull_secret_controller.go0.00%1 Missing ⚠️
...r-controller/controllers/pull_secret_controller.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1874 +/- ##
==========================================
- Coverage 69.00% 68.91% -0.09% 
==========================================
Files 66 66 Lines 5236 5241 +5 ==========================================
- Hits 3613 3612 -1 - Misses 1392 1397 +5 - Partials 231 232 +1 
FlagCoverage Δ
e2e50.36% <66.66%> (-0.07%)⬇️
unit56.74% <0.00%> (-0.06%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anik120anik120 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@camilamacedo86
camilamacedo86 added this pull request to the merge queue Mar 21, 2025
Merged via the queue into operator-framework:main with commit ef005a2Mar 21, 2025
@camilamacedo86
camilamacedo86 deleted the add-name-controller branch April 11, 2025 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@camilamacedo86@anik120