Skip to content

🌱 adopt externally-set GO_BUILD_FLAGS - #1881

Merged
perdasilva merged 1 commit into
operator-framework:mainfrom
grokspawn:adopt-build-flags
Mar 31, 2025
Merged

🌱 adopt externally-set GO_BUILD_FLAGS#1881
perdasilva merged 1 commit into
operator-framework:mainfrom
grokspawn:adopt-build-flags

Conversation

@grokspawn

Copy link
Copy Markdown
Contributor

Description

Providing the capability for targets to adopt GO_BUILD_FLAGS if set in the environment. Specifically, this is useful when shifting from a compile environment which assumes no vendoring to one which assumes vendoring.

Existing uses for this were just for unit tests, so those have been shifted to a new GO_BUILD_EXTRA_FLAGS variable.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn
grokspawn requested a review from a team as a code ownerMarch 28, 2025 14:49
@netlify

netlifyBot commented Mar 28, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitd7c4196
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67e6b707d417d300089968aa
😎 Deploy Previewhttps://deploy-preview-1881--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Mar 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.98%. Comparing base (a2ae8b8) to head (d7c4196).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1881 +/- ##
==========================================
+ Coverage 68.93% 68.98% +0.05% 
==========================================
Files 66 66 Lines 5243 5243 ==========================================
+ Hits 3614 3617 +3 + Misses 1397 1395 -2 + Partials 232 231 -1 
FlagCoverage Δ
e2e50.46% <ø> (+0.07%)⬆️
unit56.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grokspawngrokspawn changed the title adopt externally-set GO_BUILD_FLAGS🌱 adopt externally-set GO_BUILD_FLAGSMar 28, 2025
@perdasilva
perdasilva added this pull request to the merge queue Mar 31, 2025
Merged via the queue into operator-framework:main with commit db164ccMar 31, 2025
@grokspawn
grokspawn deleted the adopt-build-flags branch March 31, 2025 15:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@grokspawn@perdasilva