Skip to content

✨ Add webhook validators - #1887

Closed
perdasilva wants to merge 4 commits into
operator-framework:mainfrom
perdasilva:add-webhook-validators
Closed

✨ Add webhook validators#1887
perdasilva wants to merge 4 commits into
operator-framework:mainfrom
perdasilva:add-webhook-validators

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

Depends on #1885

Adds additional bundle validators around csv webhook configuration by ensuring:

  • webhook configurations reference existing deployment specs
  • there are no two webhooks of the same type with the same name
  • conversion webhooks reference bundle owned crds

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Per Goncalves da Silva added 2 commits April 1, 2025 12:58
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@perdasilvaperdasilva changed the title Add webhook validators✨ Add webhook validatorsApr 1, 2025
@netlify

netlifyBot commented Apr 1, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit6fa7ca5
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67ebd8e87d0e67000852e267
😎 Deploy Previewhttps://deploy-preview-1887--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilvaforce-pushed the add-webhook-validators branch from ca45978 to c97f40aCompareApril 1, 2025 11:38
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilvaforce-pushed the add-webhook-validators branch from c97f40a to 6fa7ca5CompareApril 1, 2025 12:15
@codecov

codecovBot commented Apr 1, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.81022% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.62%. Comparing base (db164cc) to head (6fa7ca5).
Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
...l/operator-controller/rukpak/convert/registryv1.go88.46%2 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1887 +/- ##
==========================================
+ Coverage 68.98% 69.62% +0.63% 
==========================================
Files 66 67 +1 Lines 5243 5366 +123 ==========================================
+ Hits 3617 3736 +119 - Misses 1395 1398 +3 - Partials 231 232 +1 
FlagCoverage Δ
e2e50.24% <45.25%> (-0.30%)⬇️
unit57.52% <93.43%> (+0.80%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@perdasilva