Skip to content

🐛 Fix bundle to plain manifest conversion - #1899

Merged
perdasilva merged 2 commits into
operator-framework:mainfrom
perdasilva:fix-convert
Apr 7, 2025
Merged

🐛 Fix bundle to plain manifest conversion#1899
perdasilva merged 2 commits into
operator-framework:mainfrom
perdasilva:fix-convert

Conversation

@perdasilva

@perdasilvaperdasilva commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Description

  • Adds dep.Spec.RevisionHistoryLimit = 1 to generated Deployment manifests to maintain OLMv0 compatibility [link]
  • Fixes permissions in AllNamespaces mode. The namespace rules were not being added to the final set of rules.

Updates generated bundle resources to reflect these changes

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerApril 4, 2025 12:09
@netlify

netlifyBot commented Apr 4, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit5e5b649
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67f407a3a91d480008abf692
😎 Deploy Previewhttps://deploy-preview-1899--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Apr 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.27%. Comparing base (7bf7e5a) to head (5e5b649).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1899 +/- ##
==========================================
+ Coverage 69.24% 69.27% +0.02% 
==========================================
Files 67 67 Lines 5307 5312 +5 ==========================================
+ Hits 3675 3680 +5 
Misses 1399 1399 Partials 233 233 
FlagCoverage Δ
e2e50.61% <100.00%> (+0.13%)⬆️
unit57.11% <100.00%> (+0.04%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Per Goncalves da Silva added 2 commits April 7, 2025 19:13
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilva added this pull request to the merge queue Apr 7, 2025

@anik120anik120 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2025
Merged via the queue into operator-framework:main with commit 1a47d64Apr 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@perdasilva@anik120