Uh oh!
There was an error while loading. Please reload this page.
🌱 Tidy up Makefile and remove convert-diff GHA - #1900
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| build-docs: | ||
| . $(VENV)/activate; \ | ||
| mkdocs build | ||
| .PHONY: serve-docs | ||
| serve-docs: venv | ||
| serve-docs: | ||
| . $(VENV)/activate; \ | ||
| mkdocs serve | ||
| .PHONY: deploy-docs | ||
| deploy-docs: venv | ||
| deploy-docs: |
There was a problem hiding this comment.
What's the story here? Makefile.venv has some doc text that makes this sounds important.
There was a problem hiding this comment.
my bad - ide was complaining so I thought they were left over from a few months back when there was some makefile refactoring. I've put them back in.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1900 +/- ##
==========================================
- Coverage 69.27% 69.21% -0.06%
==========================================
Files 67 67 Lines 5302 5302 ==========================================
- Hits 3673 3670 -3 - Misses 1397 1399 +2 - Partials 232 233 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Description
Tidies up the Makefile by combining the bundle manifest generation recipe with verify.
We also remove the convert-diff GHA in favor or running the test in the verify GHA
Reviewer Checklist