Skip to content

🌱 Add more unit testing around rukpak/convert - #1912

Merged
perdasilva merged 1 commit into
operator-framework:mainfrom
perdasilva:convert-unit-testing
Apr 11, 2025
Merged

🌱 Add more unit testing around rukpak/convert#1912
perdasilva merged 1 commit into
operator-framework:mainfrom
perdasilva:convert-unit-testing

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

Adds additional unit testing around rukpak/convert to facilitate the upcoming refactoring towards a bundle renderer

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerApril 10, 2025 08:00
@netlify

netlifyBot commented Apr 10, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit43a49ba
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67f7d28b35ce940008b370b5
😎 Deploy Previewhttps://deploy-preview-1912--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Apr 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.51%. Comparing base (0bcdd61) to head (43a49ba).
Report is 2 commits behind head on main.

Files with missing linesPatch %Lines
...operator-controller/rukpak/util/testing/testing.go91.11%4 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1912 +/- ##
==========================================
+ Coverage 69.33% 69.51% +0.18% 
==========================================
Files 67 68 +1 Lines 5312 5357 +45 ==========================================
+ Hits 3683 3724 +41 - Misses 1397 1401 +4 
Partials 232 232 
FlagCoverage Δ
e2e50.61% <ø> (-0.08%)⬇️
unit57.43% <91.11%> (+0.32%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilvaforce-pushed the convert-unit-testing branch from 60650df to 43a49baCompareApril 10, 2025 14:15
@camilamacedo86
camilamacedo86 added this pull request to the merge queue Apr 11, 2025
@camilamacedo86
camilamacedo86 removed this pull request from the merge queue due to a manual request Apr 11, 2025
@perdasilva
perdasilva added this pull request to the merge queue Apr 11, 2025
Merged via the queue into operator-framework:main with commit ed205c5Apr 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@perdasilva@thetechnick@camilamacedo86