Skip to content

🐛 Fix log initialization - #1917

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:fix-logs
Apr 14, 2025
Merged

🐛 Fix log initialization#1917
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:fix-logs

Conversation

@tmshort

Copy link
Copy Markdown
Contributor

Use proper flags and remove use of logrus and klog

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerApril 14, 2025 18:24
@netlify

netlifyBot commented Apr 14, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit20bb3ff
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67fd65adc5379b00083bc385
😎 Deploy Previewhttps://deploy-preview-1917--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshorttmshort changed the title Fix log initialization🐛 Fix log initializationApr 14, 2025
@codecov

codecovBot commented Apr 14, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (c54b571) to head (20bb3ff).
Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
cmd/catalogd/main.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1917 +/- ##
==========================================
+ Coverage 69.51% 69.53% +0.01% 
==========================================
Files 68 68 Lines 5357 5350 -7 ==========================================
- Hits 3724 3720 -4 + Misses 1401 1398 -3 
Partials 232 232 
FlagCoverage Δ
e2e50.56% <100.00%> (-0.05%)⬇️
unit57.53% <0.00%> (+0.07%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joelanford
joelanford previously approved these changes Apr 14, 2025
camilamacedo86
camilamacedo86 previously approved these changes Apr 14, 2025

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
Use proper flags and remove use of logrus and klog
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort dismissed stale reviews from camilamacedo86 and joelanford via 20bb3ffApril 14, 2025 19:44
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@tmshort
tmshort added this pull request to the merge queue Apr 14, 2025
Merged via the queue into operator-framework:main with commit 51929d2Apr 14, 2025
@tmshort
tmshort deleted the fix-logs branch April 14, 2025 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@joelanford@camilamacedo86