Skip to content

🌱 Update certpoolwatcher log levels - #1918

Merged
joelanford merged 1 commit into
operator-framework:mainfrom
tmshort:change-log-level
Apr 15, 2025
Merged

🌱 Update certpoolwatcher log levels#1918
joelanford merged 1 commit into
operator-framework:mainfrom
tmshort:change-log-level

Conversation

@tmshort

Copy link
Copy Markdown
Contributor

Some log levels were defaultLogLevel+1 (5), change those to defaultLogLevel (4)

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerApril 15, 2025 13:57
@netlify

netlifyBot commented Apr 15, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit9dfa7e1
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/67fe6c43bc6856000832372b
😎 Deploy Previewhttps://deploy-preview-1918--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Apr 15, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.53%. Comparing base (e636960) to head (9dfa7e1).
Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
internal/shared/util/http/certlog.go0.00%3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e636960) and HEAD (9dfa7e1). Click for more details.

HEAD has 2 uploads less than BASE
FlagBASE (e636960)HEAD (9dfa7e1)
unit21
e2e21
Additional details and impacted files
@@ Coverage Diff @@## main #1918 +/- ##
===========================================
- Coverage 69.53% 57.53% -12.00% 
===========================================
Files 68 68 Lines 5350 5350 ===========================================
- Hits 3720 3078 -642 - Misses 1398 2110 +712 + Partials 232 162 -70 
FlagCoverage Δ
e2e0.00% <0.00%> (-50.72%)⬇️
unit57.53% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment threadinternal/shared/util/http/certutil.go Outdated
Some log levels were defaultLogLevel+1 (5), change those to defaultLogLevel (4)
Signed-off-by: Todd Short <tshort@redhat.com>
@joelanford
joelanford enabled auto-merge April 15, 2025 14:33
@joelanford
joelanford added this pull request to the merge queue Apr 15, 2025
Merged via the queue into operator-framework:main with commit 2f22dcfApr 15, 2025
@tmshort
tmshort deleted the change-log-level branch April 15, 2025 14:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tmshort@joelanford