Skip to content

🐛 OCPBUGS-55165 Permissions preflight error output fixes - #1934

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
trgeiger:rbac-error-fixes
Apr 24, 2025
Merged

🐛 OCPBUGS-55165 Permissions preflight error output fixes#1934
tmshort merged 1 commit into
operator-framework:mainfrom
trgeiger:rbac-error-fixes

Conversation

@trgeiger

@trgeigertrgeiger commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

Description

This PR contains 2 changes:

  • Adds an errors.Join() to properly expand a list of errors that might include nil errors
  • Adds explicit rule examples to 2 of the test cases

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@trgeiger
trgeiger requested a review from a team as a code ownerApril 21, 2025 17:06
@netlify

netlifyBot commented Apr 21, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitd3edc3e
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/6807c31754c4cd00086a9fbe
😎 Deploy Previewhttps://deploy-preview-1934--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Apr 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.91%. Comparing base (e529653) to head (d3edc3e).
Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
internal/operator-controller/authorization/rbac.go0.00%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1934 +/- ##
==========================================
- Coverage 66.01% 65.91% -0.10% 
==========================================
Files 70 70 Lines 6182 6182 ==========================================
- Hits 4081 4075 -6 - Misses 1841 1845 +4 - Partials 260 262 +2 
FlagCoverage Δ
e2e45.09% <0.00%> (ø)
unit55.12% <33.33%> (-0.12%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment threadinternal/operator-controller/applier/helm.go Outdated
@bentitobentito changed the title ✨ Permissions preflight error output fixes🐛 OCPBUGS-55165 Permissions preflight error output fixesApr 21, 2025
Comment threadinternal/operator-controller/authorization/rbac_test.go
@trgeiger
trgeigerforce-pushed the rbac-error-fixes branch 4 times, most recently from cbfabeb to 24928e4CompareApril 22, 2025 16:00
Signed-off-by: Tayler Geiger <tayler@redhat.com>

@bentitobentito left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmshort
tmshort added this pull request to the merge queue Apr 24, 2025

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine for me
Thank you for the nice work 🥇
/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
Merged via the queue into operator-framework:main with commit a7ab445Apr 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@trgeiger@joelanford@bentito@camilamacedo86@tmshort