Skip to content

✨ Implement Boxcutter - #1946

Merged
thetechnick merged 33 commits into
operator-framework:mainfrom
thetechnick:poc-boxcutter
Sep 8, 2025
Merged

✨ Implement Boxcutter#1946
thetechnick merged 33 commits into
operator-framework:mainfrom
thetechnick:poc-boxcutter

Conversation

@thetechnick

Copy link
Copy Markdown
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2025
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
@netlify

netlifyBot commented Apr 30, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitc175077
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68baf6fcf5e41e00089e74de
😎 Deploy Previewhttps://deploy-preview-1946--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment threadapi/v1/clusterextensionrevision_types.go
Comment threadinternal/operator-controller/applier/boxcutter.go Outdated
Comment on lines +195 to +360
hasher.Reset()

printer := spew.ConfigState{
Indent: " ",
SortKeys: true,
DisableMethods: true,
SpewKeys: true,
}
if _, err := printer.Fprintf(hasher, "%#v", objectToWrite); err != nil {
panic(err)
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an OLM-ism or a boxcutter-ism? I wonder if json.NewEncoder(hasher).Encode(objectToWrite) would be better?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment threadinternal/operator-controller/applier/boxcutter.go Outdated
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2025
@perdasilva
perdasilvaforce-pushed the poc-boxcutter branch 2 times, most recently from 1c23866 to dc66501CompareJuly 15, 2025 11:12
@perdasilvaperdasilva changed the title POC: Implement Boxcutter✨ Implement BoxcutterJul 15, 2025
@codecov

codecovBot commented Jul 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.41553% with 313 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.03%. Comparing base (c7a6ba7) to head (c175077).
⚠️ Report is 2 commits behind head on main.

Files with missing linesPatch %Lines
...controllers/clusterextensionrevision_controller.go78.13%56 Missing and 12 partials ⚠️
internal/operator-controller/applier/boxcutter.go74.29%42 Missing and 22 partials ⚠️
api/v1/zz_generated.deepcopy.go48.62%52 Missing and 4 partials ⚠️
cmd/operator-controller/main.go72.83%31 Missing and 16 partials ⚠️
...perator-controller/rukpak/util/testing/bundlefs.go0.00%42 Missing ⚠️
internal/operator-controller/applier/helm.go57.14%10 Missing and 5 partials ⚠️
...troller/controllers/clusterextension_controller.go89.47%9 Missing and 3 partials ⚠️
internal/operator-controller/applier/preflight.go40.00%8 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1946 +/- ##
==========================================
- Coverage 72.79% 72.03% -0.76% 
==========================================
Files 79 85 +6 Lines 7421 8332 +911 ==========================================
+ Hits 5402 6002 +600 - Misses 1670 1927 +257 - Partials 349 403 +54 
FlagCoverage Δ
e2e39.42% <13.67%> (-4.78%)⬇️
experimental-e2e46.10% <58.40%> (-10.03%)⬇️
unit56.67% <44.10%> (-1.69%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva
perdasilvaforce-pushed the poc-boxcutter branch 6 times, most recently from 35cdf3b to 370bac6CompareJuly 21, 2025 16:28
Comment threadscripts/install.tpl.sh Outdated
@perdasilva
perdasilvaforce-pushed the poc-boxcutter branch 9 times, most recently from 4f39c38 to 842037eCompareJuly 23, 2025 15:27
Per Goncalves da Silvaand others added 28 commits September 5, 2025 16:42
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
…re component
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Todd Short <tshort@redhat.com>
Signed-off-by: Todd Short <tshort@redhat.com>
Ensure informers are started before reconciling and stopped before
removing the finalizer.
…on annotations
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
This change accommodates the possibility of a revision that is currently
rolling out, which is possible for appliers that perform rollouts
asynchronously.
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
…conciliation
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Defines a set of phases which facilitate a smoother installation vs applying every resource in the bundle all at once.
Signed-off-by: Daniel Franz <dfranz@redhat.com>
Captures conditions and reasons used by ClusterExtensionRevision into consts.
Signed-off-by: Daniel Franz <dfranz@redhat.com>
@thetechnick
thetechnick merged commit e88a6ea into operator-framework:mainSep 8, 2025
23 of 25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@thetechnick@joelanford@perdasilva@tmshort@openshift-merge-robot@dtfranz