Skip to content

📖 [doc] Initial draft doc preflight perms - #1950

Merged
bentito merged 2 commits into
operator-framework:mainfrom
bentito:draft-doc-rbac-perms
May 29, 2025
Merged

📖 [doc] Initial draft doc preflight perms#1950
bentito merged 2 commits into
operator-framework:mainfrom
bentito:draft-doc-rbac-perms

Conversation

@bentito

@bentitobentito commented May 6, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@bentito
Initial draft doc preflight perms
8bab988
Signed-off-by: Brett Tofel <btofel@redhat.com>
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
@netlify

netlifyBot commented May 6, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit5c7bb63
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/682259cc2e97ae000879a9d5
😎 Deploy Previewhttps://deploy-preview-1950--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented May 6, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.82%. Comparing base (540804c) to head (5c7bb63).
Report is 23 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1950 +/- ##
==========================================
+ Coverage 66.78% 66.82% +0.04% 
==========================================
Files 75 75 Lines 6337 6337 ==========================================
+ Hits 4232 4235 +3 + Misses 1841 1839 -2 + Partials 264 263 -1
FlagCoverage Δ
e2e45.25% <ø> (+0.06%)⬆️
unit56.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bentitobentito mentioned this pull request May 6, 2025
Closed
michaelryanpeter
michaelryanpeter approved these changes May 12, 2025
View reviewed changes

@michaelryanpetermichaelryanpeter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@openshift-ci

openshift-ciBot commented May 12, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelryanpeter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@bentito

bentito commented May 12, 2025

Copy link
Copy Markdown
ContributorAuthor

/hold

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2025
@bentito
bentito marked this pull request as ready for review May 12, 2025 20:27
@bentito
bentito requested a review from a team as a code ownerMay 12, 2025 20:27
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2025
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@openshift-ci

openshift-ciBot commented May 12, 2025

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@bentitobentito changed the title [📖 ] WIP Initial draft doc preflight perms[📖 ] Initial draft doc preflight permsMay 12, 2025
@bentitobentito changed the title [📖 ] Initial draft doc preflight perms[📖] Initial draft doc preflight permsMay 12, 2025
@bentitobentito changed the title [📖] Initial draft doc preflight perms📖 [doc] Initial draft doc preflight permsMay 13, 2025
@bentito
bentito merged commit ab1191b into operator-framework:mainMay 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gallettilancegallettilanceAwaiting requested review from gallettilance
@rashmigottipatirashmigottipatiAwaiting requested review from rashmigottipati
1 more reviewer
@michaelryanpetermichaelryanpetermichaelryanpeter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@michaelryanpetermichaelryanpeter

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bentito@michaelryanpeter