Skip to content

✨ Move NetworkPolicies into a subdirectory - #1952

Closed
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:component-np
Closed

✨ Move NetworkPolicies into a subdirectory#1952
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:component-np

Conversation

@tmshort

@tmshorttmshort commented May 6, 2025

Copy link
Copy Markdown
Contributor

Follow up to #1942
This moves the NetworkPolicies into a component that can be applied as part of an existing overlay, removing them from the base config.

This is to fix an issue with downstream that does not understand v1.NetworkPolicies.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerMay 6, 2025 15:03
@netlify

netlifyBot commented May 6, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit8c25fbd
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/681b9b1d0002070008665dbf
😎 Deploy Previewhttps://deploy-preview-1952--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented May 6, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (bfac51c) to head (8c25fbd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1952 +/- ##
==========================================
+ Coverage 66.75% 66.77% +0.01% 
==========================================
Files 75 75 Lines 6335 6335 ==========================================
+ Hits 4229 4230 +1 + Misses 1842 1841 -1 
Partials 264 264
FlagCoverage Δ
e2e45.21% <ø> (ø)
unit56.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
tmshortforce-pushed the component-np branch 2 times, most recently from c973f69 to 7a650d8CompareMay 6, 2025 18:09
@tmshorttmshort changed the title ✨ Move NetworkPolicies into a config component✨ Move NetworkPolicies into a subdirectoryMay 6, 2025
@tmshort
Move NetworkPolicies into a subdirectory
8c25fbd
Follow up to operator-framework#1942
This moves the NetworkPolicies into a subdirectory from the manager config.
It allows downstream to pick-and-choose what to pull in.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort

tmshort commented May 7, 2025

Copy link
Copy Markdown
ContributorAuthor

/hold
May not be needed if downstream stuff merges.

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2025
camilamacedo86
camilamacedo86 approved these changes May 7, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm
/approve

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
@openshift-ci

openshift-ciBot commented May 7, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@tmshort

tmshort commented May 12, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

No longer needed.

@tmshorttmshort closed this May 12, 2025
@tmshort
tmshort deleted the component-np branch May 12, 2025 02:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@gallettilancegallettilanceAwaiting requested review from gallettilance
@OchiengEdOchiengEdAwaiting requested review from OchiengEd

Assignees

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmshort@camilamacedo86