Skip to content

⚠️ OPRUN-3954: Update CRD generator to support experimental CRDs - #1980

Merged
tmshort merged 3 commits into
operator-framework:mainfrom
tmshort:api-generator-test
Jun 24, 2025
Merged

⚠️ OPRUN-3954: Update CRD generator to support experimental CRDs#1980
tmshort merged 3 commits into
operator-framework:mainfrom
tmshort:api-generator-test

Conversation

@tmshort

@tmshorttmshort commented May 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix#2014

Add support for a new CRD generator. This generator will use opcon
tags to identify experimental features. A script runs the CRD
generation, and creates all the CRDs.

New experimental CRDs are now created.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerMay 20, 2025 20:44
@netlify

netlifyBot commented May 20, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit67e085b
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6859e8fa5524250008e4f584
😎 Deploy Previewhttps://deploy-preview-1980--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshorttmshort added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@codecov

codecovBot commented May 20, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.35545% with 52 lines in your changes missing coverage. Please review.

Project coverage is 73.87%. Comparing base (d844c45) to head (67e085b).
Report is 4 commits behind head on main.

Files with missing linesPatch %Lines
hack/tools/crd-generator/main.go75.35%35 Missing and 17 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1980 +/- ##
==========================================
+ Coverage 73.86% 73.87% +0.01% 
==========================================
Files 80 81 +1 Lines 7154 7365 +211 ==========================================
+ Hits 5284 5441 +157 - Misses 1548 1584 +36 - Partials 322 340 +18
FlagCoverage Δ
e2e44.10% <ø> (-0.05%)⬇️
unit60.66% <75.35%> (+0.44%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
tmshortforce-pushed the api-generator-test branch 4 times, most recently from a5c717d to 6a6c223CompareMay 21, 2025 18:39
@tmshort

tmshort commented Jun 5, 2025

Copy link
Copy Markdown
ContributorAuthor

/unhold

@tmshort
tmshortforce-pushed the api-generator-test branch from 6a6c223 to 778d86cCompareJune 5, 2025 18:12
@tmshorttmshort changed the title ⚠️ WIP: crd-generator-work⚠️ Update CRD generator to support experimental CRDsJun 5, 2025
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@tmshort

tmshort commented Jun 5, 2025

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@tmshort
tmshortforce-pushed the api-generator-test branch from e6b2315 to 953be02CompareJune 12, 2025 18:54
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2025
@tmshort
tmshortforce-pushed the api-generator-test branch from 953be02 to dc3d821CompareJune 17, 2025 12:34
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@tmshort
Update CRD generator to support experimental CRDs
30aeef7
Add support for a new CRD generator. This generator will use `opcon`
tags to identify experimental features. A script runs the CRD
generation, and creates all the CRDs.
New experimental CRDs are now created.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshortforce-pushed the api-generator-test branch from dc3d821 to 30aeef7CompareJune 23, 2025 18:52
@tmshorttmshort changed the title ⚠️ Update CRD generator to support experimental CRDs⚠️ OPRUN-3954: Update CRD generator to support experimental CRDsJun 24, 2025
@tmshort

tmshort commented Jun 24, 2025

Copy link
Copy Markdown
ContributorAuthor

Yes, crd-diff is failing, because I moved the location of the CRD file.

camilamacedo86
camilamacedo86 approved these changes Jun 24, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we have the experimental fields to ensure that it works well as expected. However, I think we can change and improve in follow ups if you need to.

So, it seems good enough as first step at least

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
@openshift-ci

openshift-ciBot commented Jun 24, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort

tmshort commented Jun 24, 2025

Copy link
Copy Markdown
ContributorAuthor

It would be nice if we have the experimental fields to ensure that it works well as expected. However, I think we can change and improve in follow ups if you need to.

The unit test does try to use some experimental fields, but we don't have any in the main codebase.

@tmshort
tmshort merged commit 9380928 into operator-framework:mainJun 24, 2025
@tmshort
tmshort deleted the api-generator-test branch June 24, 2025 13:36
@camilamacedo86camilamacedo86 mentioned this pull request Jun 25, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@grokspawngrokspawnAwaiting requested review from grokspawn

Assignees

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce New CRD Generation Tooling

3 participants

@tmshort@camilamacedo86@openshift-merge-robot