Skip to content

🐛 Fix webhook service rotation to renew within 24h of expiry - #1997

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:webhook-fix-rotation
May 28, 2025
Merged

🐛 Fix webhook service rotation to renew within 24h of expiry#1997
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:webhook-fix-rotation

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

Currently, the generated webhook certificate is set to rotate 1 year before expiry. In this PR we set it to 24h to keep parity with OLMv0 behavior.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerMay 28, 2025 08:42
@netlify

netlifyBot commented May 28, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit0cfbe80
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6836f37af34cfa0008dbc9c1
😎 Deploy Previewhttps://deploy-preview-1997--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@codecov

codecovBot commented May 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.11%. Comparing base (71108b2) to head (0cfbe80).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1997 +/- ##
=======================================
Coverage 69.11% 69.11% =======================================
Files 79 79 Lines 7023 7027 +4 =======================================
+ Hits 4854 4857 +3 - Misses 1887 1888 +1 
Partials 282 282 
FlagCoverage Δ
e2e43.08% <0.00%> (-0.04%)⬇️
unit59.99% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment threadinternal/operator-controller/rukpak/render/certproviders/certmanager.go Outdated
@perdasilva
perdasilvaforce-pushed the webhook-fix-rotation branch from cf52a50 to 0cfbe80CompareMay 28, 2025 11:28

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🎉

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 52b1265 into operator-framework:mainMay 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@perdasilva@camilamacedo86