Skip to content

🌱 Bundle renderer refactor webhook service related function and attribute naming - #1999

Merged
openshift-merge-bot[bot] merged 2 commits into
operator-framework:mainfrom
perdasilva:renderer-fixups
May 28, 2025
Merged

🌱 Bundle renderer refactor webhook service related function and attribute naming#1999
openshift-merge-bot[bot] merged 2 commits into
operator-framework:mainfrom
perdasilva:renderer-fixups

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

Minor refactor renaming the WebhookServiceGenerator and WebhookService attribute in the cert provider configuration. The naming is not accurate in the sense that the service is not necessarily exclusive to webhooks. In some future, if we want to implement, e.g. APIService support, the same service will be used. These are rather services that are backed by the deployments in described in the CSV.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Per Goncalves da Silva added 2 commits May 28, 2025 13:13
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
…viceResourceGenerator
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilva requested a review from a team as a code ownerMay 28, 2025 11:17
@netlify

netlifyBot commented May 28, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit29c5046
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6836f0b36399dd0008bba715
😎 Deploy Previewhttps://deploy-preview-1999--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@perdasilvaperdasilva changed the title 🌱 Renderer fixups🌱 Bundle renderer refactor webhook service related function and attribute namingMay 28, 2025
@codecov

codecovBot commented May 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.11%. Comparing base (71108b2) to head (29c5046).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1999 +/- ##
=======================================
Coverage 69.11% 69.11% =======================================
Files 79 79 Lines 7023 7023 =======================================
Hits 4854 4854 Misses 1887 1887 Partials 282 282 
FlagCoverage Δ
e2e43.11% <38.46%> (ø)
unit59.97% <100.00%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CertName: "cert",
Namespace: "namespace",
CertProvider: nil,
ServiceName: "webhook",

@camilamacedo86camilamacedo86May 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit ac14a4e into operator-framework:mainMay 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@perdasilva@camilamacedo86