🌱 migrate from github.com/everettraven/crd-diff to sigs.k8s.io/crdify

[everettraven]

Description

This updates the usage of github.com/everettraven/crd-diff in CI to sigs.k8s.io/crdify as the project has now been donated under the umbrella of sig-api-machinery.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	73ec45b
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/685da59251e8770008987186
😎 Deploy Preview	https://deploy-preview-2010--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[everettraven]

Note for reviewers: This is technically a less restrictive config than existed before, but IIRC it was planned to add new enum values in various places during continued development of OLMv1 so this felt reasonable to include.

If you want to maintain the strictest possible configuration, the options here could be to:

• Remove the use of a configuration file as crdify defaults to the strictest possible analysis
• Switch additionPolicy to Disallow (keeps the config file around)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.80%. Comparing base (a449fc4) to head (73ec45b).
Report is 8 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #2010 +/- ##
==========================================
- Coverage 73.82% 73.80% -0.02% 
==========================================
Files 81 81 Lines 7365 7365 ==========================================
- Hits 5437 5436 -1 - Misses 1588 1589 +1 
Partials 340 340 

Flag	Coverage Δ
e2e	44.10% <ø> (+0.04%)	⬆️
unit	60.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[perdasilva]

@everettraven because this pulls in go1.24, we won't be able to merge it T_T

[everettraven]

@perdasilva I noted that in a Slack message I sent to the olm-dev channel :)

I imagine that you'll be bumping to go 1.24 at some point? I'm happy for this to be held until that point. I don't think this is urgent

[camilamacedo86]

This looks great — we just need to wait until we can use Go 1.24 to move forward with it. Everything else is looking solid 🎉

Thanks for coming back and contributing toward this!
/hold until there.

cc @grokspawn@tmshort — another one queued up for when we’re able to move to Go 1.24, just FYI for your ACK.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Hi @everettraven

Can you please rebase it with main branch and ensure that we use go 1.24.3 so that we can get this one merged?

[openshift-ci]

New changes are detected. LGTM label has been removed.

[everettraven]

@camilamacedo86 done

[camilamacedo86]

Hi @everettraven

Can you please rebase again ?
So that we can get it merged?

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[perdasilva]

closing this as stale - please re-open if its still important