Uh oh!
There was an error while loading. Please reload this page.
🌱 Add manifests directory - #2025
Conversation
tmshort
commented
Jun 12, 2025
/approve |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| # Generate the remaining catalogd manifests | ||
| $(CONTROLLER_GEN) --load-build-tags=$(GO_BUILD_TAGS) rbac:roleName=manager-role paths="./internal/catalogd/..." output:rbac:artifacts:config=$(KUSTOMIZE_CATD_RBAC_DIR) | ||
| $(CONTROLLER_GEN) --load-build-tags=$(GO_BUILD_TAGS) webhook paths="./internal/catalogd/..." output:webhook:artifacts:config=$(KUSTOMIZE_CATD_WEBHOOKS_DIR) | ||
| # Generate the checked-in manifests |
There was a problem hiding this comment.
nit: the use of the phrase "checked-in" here and in other places is most likely going to be a source of confusion for future maintainers. Maybe
Generate manifests to be committed to version control or Generate and store manifests in the manifests directory, for distribution ?
There was a problem hiding this comment.
"checked-in" is a very common term for code that's in source control.
| quickstart: $(KUSTOMIZE) manifests #EXHELP Generate the unified installation release manifests and scripts. | ||
| $(KUSTOMIZE) build $(KUSTOMIZE_BUILD_DIR) | sed "s/cert-git-version/cert-$(VERSION)/g" | sed "s/:devel/:$(VERSION)/g" > $(RELEASE_MANIFEST) | ||
| quickstart: manifests #EXHELP Generate the unified installation release manifests and scripts. | ||
| # Update the image version in the standard manifests |
There was a problem hiding this comment.
| # Update the image version in the standard manifests | |
| # Update the image version in the stored manifests |
There was a problem hiding this comment.
The use use of the term "standard" is a reflection of the nature of the manifests as described in the Feature Gated APIs RFC.
Check-in manifests to the manifests directory. Currently, there is: * "standard" manifests, which is used as the basis for e2e and quickstart * "cluster-catalogs" manifests, which is just moved from the config dir Signed-off-by: Todd Short <tshort@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #2025 +/- ##
=======================================
Coverage 69.28% 69.28% =======================================
Files 79 79 Lines 7051 7051 =======================================
Hits 4885 4885 Misses 1884 1884 Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Check-in manifests to the manifests directory.
Currently, there is:
This is a quick/simple start to some of the Feature-Gated API work.
Description
Reviewer Checklist