Skip to content

✨ upgrade controller-runtime and k8s dependencies to support k8s 1.33 - #2038

Merged
tmshort merged 3 commits into
operator-framework:mainfrom
camilamacedo86:up-controller-runtime
Jun 24, 2025
Merged

✨ upgrade controller-runtime and k8s dependencies to support k8s 1.33#2038
tmshort merged 3 commits into
operator-framework:mainfrom
camilamacedo86:up-controller-runtime

Conversation

@camilamacedo86

@camilamacedo86camilamacedo86 commented Jun 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@camilamacedo86
camilamacedo86 requested a review from a team as a code ownerJune 23, 2025 17:29
@netlify

netlifyBot commented Jun 23, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit5bebe1c
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/685ad65c91b80d0008838f98
😎 Deploy Previewhttps://deploy-preview-2038--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camilamacedo86
camilamacedo86force-pushed the up-controller-runtime branch 2 times, most recently from 2fd65cf to a87b2f7CompareJune 23, 2025 18:06
@codecov

codecovBot commented Jun 23, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.82%. Comparing base (10d8d79) to head (beb855e).

Files with missing linesPatch %Lines
...-controller/contentmanager/source/dynamicsource.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2038 +/- ##
==========================================
- Coverage 73.87% 73.82% -0.06% 
==========================================
Files 81 81 Lines 7365 7365 ==========================================
- Hits 5441 5437 -4 - Misses 1584 1588 +4 
Partials 340 340
FlagCoverage Δ
e2e44.10% <0.00%> (-0.05%)⬇️
unit60.25% <0.00%> (-0.40%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Jun 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

/hold
We aren't ready for go 1.24

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2025
@camilamacedo86

camilamacedo86 commented Jun 24, 2025

Copy link
Copy Markdown
ContributorAuthor

/hold cancel

We can move forward now :-)
@tmshort wiating for your approval here

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2025
@tmshorttmshort added the override-go-verdiff Override the go-verdiff test result. If this label is present the golang version has changed! label Jun 24, 2025
@tmshort

tmshort commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
anik120
anik120 approved these changes Jun 24, 2025
View reviewed changes

@anik120anik120 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
@openshift-ci

openshift-ciBot commented Jun 24, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort

tmshort commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

#2043 merged to fix e2e-kind, so you may need to rebase again... but I can try to rerun e2e-kind

@tmshort

tmshort commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Needs a rebase...

@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
@camilamacedo86camilamacedo86 changed the title ✨ upgrade controller-runtime and k8s dependencies to support k8s 1.33✨ upgrade controller-runtime, controller-gen and k8s dependencies to support k8s 1.33Jun 24, 2025
@camilamacedo86camilamacedo86 changed the title ✨ upgrade controller-runtime, controller-gen and k8s dependencies to support k8s 1.33✨ upgrade controller-runtime and k8s dependencies to support k8s 1.33Jun 24, 2025
@camilamacedo86camilamacedo86 added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
@tmshort

tmshort commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
@tmshort
tmshort merged commit 20d0880 into operator-framework:mainJun 24, 2025
@camilamacedo86
camilamacedo86 deleted the up-controller-runtime branch June 24, 2025 17:09
@tmshort

tmshort commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

This PR seems to be causing problems when running make test-e2e locally.

@camilamacedo86

camilamacedo86 commented Jun 25, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This PR seems to be causing problems when running make test-e2e locally.

Everything is working fine for me on Mac and in the CI, which is Linux, and is calling it.
Let's discuss it on Slack and see why it does not work in your environment.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomasankitathomasAwaiting requested review from ankitathomas
@LalatenduMohantyLalatenduMohantyAwaiting requested review from LalatenduMohanty
@tmshorttmshortAwaiting requested review from tmshort
@grokspawngrokspawnAwaiting requested review from grokspawn
1 more reviewer
@anik120anik120anik120 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@anik120anik120

@tmshorttmshort

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.override-go-verdiffOverride the go-verdiff test result. If this label is present the golang version has changed!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camilamacedo86@tmshort@anik120