Skip to content

🌱 Upgrade golang-ci from v1 to latest v2 and fix lint issues - #2045

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
camilamacedo86:golang-ci
Jun 27, 2025
Merged

🌱 Upgrade golang-ci from v1 to latest v2 and fix lint issues#2045
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
camilamacedo86:golang-ci

Conversation

@camilamacedo86

Copy link
Copy Markdown
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86
camilamacedo86 requested a review from a team as a code ownerJune 24, 2025 17:55
@netlify

netlifyBot commented Jun 24, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commite0172b3
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/685d5ca9f2958f0008d3fc73
😎 Deploy Previewhttps://deploy-preview-2045--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camilamacedo86camilamacedo86 changed the title Upgrade golang-ci from v1 to latest v2WIP: Upgrade golang-ci from v1 to latest v2Jun 24, 2025
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2025
@codecov

codecovBot commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.82%. Comparing base (fca620f) to head (e0172b3).
Report is 8 commits behind head on main.

Files with missing linesPatch %Lines
...troller/controllers/clusterextension_controller.go50.00%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2045 +/- ##
==========================================
+ Coverage 73.80% 73.82% +0.01% 
==========================================
Files 81 81 Lines 7365 7365 ==========================================
+ Hits 5436 5437 +1 + Misses 1589 1588 -1 
Partials 340 340 
FlagCoverage Δ
e2e44.10% <80.00%> (-0.05%)⬇️
unit60.25% <66.66%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86camilamacedo86 changed the title WIP: Upgrade golang-ci from v1 to latest v2🌱 Upgrade golang-ci from v1 to latest v2 and fix lint issuesJun 24, 2025
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/lgtm
/approve
Looks good to me; the changes are minor and reasonable. Ran lint local, no problems.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 475e797 into operator-framework:mainJun 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@camilamacedo86@tmshort