Uh oh!
There was an error while loading. Please reload this page.
🐛 Update kindest/node image to v1.33.1 via kind v0.29.0 - #2047
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #2047 +/- ##
=======================================
Coverage 73.82% 73.82% =======================================
Files 81 81 Lines 7365 7365 =======================================
Hits 5437 5437 Misses 1588 1588 Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmshort
commented
Jun 25, 2025
/approve |
| # The K8S_VERSION is set by getting the version of the k8s.io/client-go dependency from the go.mod | ||
| # and sets major version to "1" and the patch version to "0". For example, a client-go version of v0.28.5 | ||
| # will map to a K8S_VERSION of 1.28.0 | ||
| ifeq ($(K8S_VERSION),1.33) |
There was a problem hiding this comment.
Why would we pin to the 0-th patch version of the aligned kube release? That feels like a false dependency, where the real solution is to ensure that our kube/kind dependencies were always aligned (for e.g. as go-verdiff evals that we sync golang bumps, we should also bump kind when we bump kube).
Please
/hold
while we discuss
There was a problem hiding this comment.
Clarification on KIND and node image versions:
Just to clarify, kind is the tool, while the node image refers to the Kubernetes version/image used—these are distinct.
✅ The node image is automatically updated based on the go.mod, which is why we’re already using Kubernetes v1.33.
So what you're asking about is actually already handled.
📌 We have a separate PR to update kind along with the other Bingo-managed tools: #2037
We usually avoid combining all updates in one PR to keep reviews focused and manageable.
So, for me it is great if that solves the specific issue faced with Fedora.
/lgtm
/approved
There was a problem hiding this comment.
Disagree.
The node image is getting pinned here to the $kube-version.0 (0 patch version) for the underlying kube version.
This effectively prevents us from using any updated node images released by kind, unless they re-release them under the same patch version, which isn't sane.
I think @joelanford participated in the initial discussion on this issue, and I think the argument had been that we would continue support for kube bump minor releases as long as we stayed on that kube version... but I admit that it's been a minute and my recollection might not be exact.
But in this case we are overriding the defaults of a version of the tool that we deliberately chose, which feels a bit like needlessly fighting ourselves.
I am not convinced that the expediency of this solution necessitates haste here.
There was a problem hiding this comment.
I will just add that changing the kind node version from 1.33.0 to 1.33.1 makes Makefile targets work for me again on f42.
bentito
commented
Jun 25, 2025
/lgtm |
Rather than assuming we should use a version of kindest/node based on our version of k8s in go.mod (with a .0 patch), we check to esnure that the version kind uses is compatible with our k8s major.minor version. We discovered this problem because it appears that kindest/node:v1.33.0 has issues with some systems (e.g. Fedora). Using kindest/node:v1.33.1 fixes this issue. So, we don't want to fix a .0 patch version. We want to ensure that the kindest/node image is compatible. Also note that kind never used kindest/node:v1.33.0 as a default image, kind v0.28.0/v0.29.0 use kindest/node:v1.33.1. Signed-off-by: Todd Short <tshort@redhat.com>
4458a39 to
b411224Compare
camilamacedo86
left a comment
There was a problem hiding this comment.
That is a better solution yet.
Great 🎉
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort, trgeiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tmshort
commented
Jun 26, 2025
/unhold |
| .PHONY: kind-cluster | ||
| kind-cluster: $(KIND) #EXHELP Standup a kind cluster. | ||
| env K8S_VERSION=v$(K8S_VERSION) KIND=$(KIND) GOBIN=$(GOBIN) hack/tools/validate_kindest_node.sh |
There was a problem hiding this comment.
Didn't get to this yesterday, but would've preferred to keep this check separate from the cluster creation step, so we could include it in the verify target.
Rather than assuming we should use a version of kindest/node based on our version of k8s in go.mod (with a .0 patch), we check to ensure that the version kind uses is compatible with our k8s major.minor version.
We discovered this problem because it appears that kindest/node:v1.33.0 has issues with some systems (e.g. Fedora).
Using kindest/node:v1.33.1 fixes this issue. So, we don't want to fix a .0 patch version. We want to ensure that the kindest/node image is compatible.
Also note that kind never used kindest/node:v1.33.0 as a default image, kind v0.28.0/v0.29.0 use kindest/node:v1.33.1.
Description
Reviewer Checklist