Skip to content

🐛 Fix Prometheus Using Endpoints - #2049

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
dtfranz:prometheus-endpointslices
Jun 26, 2025
Merged

🐛 Fix Prometheus Using Endpoints#2049
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
dtfranz:prometheus-endpointslices

Conversation

@dtfranz

@dtfranzdtfranz commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Description

Endpoints, which Prometheus uses by default, are now fully deprecated since kind has been updated and we need to add configuration to tell Prometheus to use EndpointSlices instead.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Now that the version of kubernetes we're using in CI has been increased, Endpoints, which Prometheus uses by default, are deprecated and we need to add configuration to tell Prometheus to use EndpointSlices instead.
Signed-off-by: Daniel Franz <dfranz@redhat.com>
@dtfranz
dtfranz requested a review from a team as a code ownerJune 26, 2025 08:29
@netlify

netlifyBot commented Jun 26, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit7c1a2ca
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/685d05074aabec0008fe0755
😎 Deploy Previewhttps://deploy-preview-2049--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@codecov

codecovBot commented Jun 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.82%. Comparing base (b02314b) to head (7c1a2ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2049 +/- ##
=======================================
Coverage 73.82% 73.82% =======================================
Files 81 81 Lines 7365 7365 =======================================
Hits 5437 5437 Misses 1588 1588 Partials 340 340 
FlagCoverage Δ
e2e44.10% <ø> (+0.04%)⬆️
unit60.24% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot
openshift-merge-botBot merged commit 20af238 into operator-framework:mainJun 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dtfranz@camilamacedo86