Skip to content

✨ Add standard-e2e manifest - #2056

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:add-standard-e2e
Jun 26, 2025
Merged

✨ Add standard-e2e manifest#2056
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:add-standard-e2e

Conversation

@tmshort

Copy link
Copy Markdown
Contributor

This renames two overlays:

  • cert-manager -> standard
  • e2e -> standard-e2e

This also adds a new manifest:

  • manifests/standard-e2e.yaml

This fixes the issue with the current test-e2e modifying the standard manifest with e2e parameters, leaving a dirty workspace. This changes the manifest used by the e2e test to be it's own standard-e2e manifest.

This is part of the feature-gated API functionality.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

This renames two overlays:
* cert-manager -> standard
* e2e -> standard-e2e
This also adds a new manifest:
* manifests/standard-e2e.yaml
This fixes the issue with the current test-e2e modifying the standard
manifest with e2e parameters, leaving a dirty workspace. This changes
the manifest used by the e2e test to be it's own standard-e2e manifest.
This is part of the feature-gated API functionality.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort requested a review from a team as a code ownerJune 26, 2025 18:03
@netlify

netlifyBot commented Jun 26, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit647ba00
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/685d8b8887b7180008bdff5c
😎 Deploy Previewhttps://deploy-preview-2056--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@codecov

codecovBot commented Jun 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.82%. Comparing base (10f4a19) to head (647ba00).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2056 +/- ##
==========================================
+ Coverage 73.80% 73.82% +0.01% 
==========================================
Files 81 81 Lines 7365 7365 ==========================================
+ Hits 5436 5437 +1 + Misses 1589 1588 -1 
Partials 340 340 
FlagCoverage Δ
e2e44.15% <ø> (+0.04%)⬆️
unit60.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grokspawn

Copy link
Copy Markdown
Contributor

Had a side-channel convo with @tmshort about possible impacts to plans to open up the PKI model to accept other providers (for instance, currently we rely very heavily on certmanager, but others could be used like openshift/serviceca).

It sounds like we need to resolve that question separately, and that any change to that would inescapably require new changes to this area anyway, so no opportunity to "leave room" for it here.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 089aa45 into operator-framework:mainJun 26, 2025
@tmshort

Copy link
Copy Markdown
ContributorAuthor

@grokspawn openshift's serviceca is already handled by separate downstream overlays; so it certainly is possible. By keeping the cert-manager items separate (they are in the component/tls directory), they are easily replaceable.

@tmshort
tmshort deleted the add-standard-e2e branch June 26, 2025 19:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tmshort@grokspawn