Skip to content

🌱 Move feature overlays to components - #2059

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:move-features
Jun 26, 2025
Merged

🌱 Move feature overlays to components#2059
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:move-features

Conversation

@tmshort

@tmshorttmshort commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Move the current feature overlays to be components. This will allow them to be brought into an experimental overlay in the near future.

These are currently unused.

This is part of the feature-gated API functionality.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Move feature overlays to components
289e68d
Move the current feature overlays to be components. This will allow
them to be brought into an experimental overlay in the near future.
These are currently unused.
This is part of the feature-gated API functionality.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort requested a review from a team as a code ownerJune 26, 2025 19:35
@netlify

netlifyBot commented Jun 26, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit289e68d
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/685da0fab733180008bcc180
😎 Deploy Previewhttps://deploy-preview-2059--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort

tmshort commented Jun 26, 2025

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@codecov

codecovBot commented Jun 26, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (089aa45) to head (289e68d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2059 +/- ##
==========================================
- Coverage 73.80% 70.15% -3.66% 
==========================================
Files 81 81 Lines 7365 7365 ==========================================
- Hits 5436 5167 -269 - Misses 1589 1895 +306 + Partials 340 303 -37
FlagCoverage Δ
e2e36.03% <ø> (-8.04%)⬇️
unit60.23% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Jun 26, 2025

Copy link
Copy Markdown
ContributorAuthor

Wow... look at codecov.... changing by 3% when there's no code changes...

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
@openshift-ci

openshift-ciBot commented Jun 26, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86

camilamacedo86 commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@tmshort
tmshort merged commit 2c585f7 into operator-framework:mainJun 26, 2025
@tmshort
tmshort deleted the move-features branch June 26, 2025 20:52
@tmshorttmshort mentioned this pull request Jun 29, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@gallettilancegallettilanceAwaiting requested review from gallettilance

Assignees

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmshort@camilamacedo86