Uh oh!
There was an error while loading. Please reload this page.
🌱 Rename tls component to cert-manager and consolidate - #2060
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This renames the tls component to cert-manager to reflect what it really is. A kustomization.yaml file is added to cert-manager to make it behave as a single component. This will make it easier to manage this component, and allow for easier future replacement. This is part of the feature-gated API functionality. Signed-off-by: Todd Short <tshort@redhat.com>
e94a209 to
264f958Compare| # ca must be last or other components will overwrite the namespaces | ||
| - ../../components/tls/ca | ||
| # This must be last due to namespace overwrite issues of the ca | ||
| - ../../components/cert-manager |
There was a problem hiding this comment.
That make sense if we want add the OCP CA in upstream as well.
I understood that we were looking for that so we could have another componet for it too
/lgtm
There was a problem hiding this comment.
Yes, that's the idea, if we ever want to swap certificate providers, this will make it easier.
I may try to update this to avoid this weird namespace mechanism... @joelanford had something in older refactoring PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #2060 +/- ##
==========================================
- Coverage 73.82% 73.80% -0.02%
==========================================
Files 81 81 Lines 7365 7365 ==========================================
- Hits 5437 5436 -1 - Misses 1588 1589 +1
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmshort
commented
Jun 27, 2025
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This renames the tls component to cert-manager to reflect what it really is. A kustomization.yaml file is added to cert-manager to make it behave as a single component. This will make it easier to manage this component, and allow for easier future replacement.
This is part of the feature-gated API functionality.
Description
Reviewer Checklist