Skip to content

🌱 Add more feature gate configuration to experimental - #2068

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:more-features
Jul 2, 2025
Merged

🌱 Add more feature gate configuration to experimental#2068
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:more-features

Conversation

@tmshort

@tmshorttmshort commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Add the following feature gates to the experimental manifests:

  • APIV1MetasHandler
  • SingleOwnNamespaceInstallSupport
  • PReflightPermissions

Update manifests

Add the regular e2e tests into the experimental-e2e tests. This makes the experimental-e2e longer, but it should help with coverage.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Add more feature gate configuration to experimental
9b7b01c
Add the following feature gates to the experimental manifests:
* APIV1MetasHandler
* SingleOwnNamespaceInstallSupport
* PReflightPermissions
Update manifests
Add the regular e2e tests into the experimental-e2e tests. This makes
the experimental-e2e longer, but it should help with coverage.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort requested a review from a team as a code ownerJuly 1, 2025 20:53
@netlify

netlifyBot commented Jul 1, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit9b7b01c
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68644ae3b72d12000817d63a
😎 Deploy Previewhttps://deploy-preview-2068--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecovBot commented Jul 1, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (5686577) to head (9b7b01c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2068 +/- ##
==========================================
+ Coverage 73.94% 74.69% +0.74% 
==========================================
Files 81 81 Lines 7365 7365 ==========================================
+ Hits 5446 5501 +55 + Misses 1582 1527 -55 
Partials 337 337
FlagCoverage Δ
e2e44.15% <ø> (ø)
experimental-e2e50.04% <ø> (+29.90%)⬆️
unit60.24% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Jul 1, 2025

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
camilamacedo86
camilamacedo86 reviewed Jul 2, 2025
View reviewed changes
Comment threadMakefile
test-experimental-e2e: KIND_CLUSTER_NAME := operator-controller-e2e
test-experimental-e2e: GO_BUILD_EXTRA_FLAGS := -cover
test-experimental-e2e: run image-registry prometheus experimental-e2e e2e-metrics e2e-coverage kind-clean #HELP Run experimental e2e test suite on local kind cluster
test-experimental-e2e: run image-registry prometheus experimental-e2e e2e e2e-metrics e2e-coverage kind-clean #HELP Run experimental e2e test suite on local kind cluster

@camilamacedo86camilamacedo86Jul 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Make sense

camilamacedo86
camilamacedo86 approved these changes Jul 2, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2025
@openshift-ci

openshift-ciBot commented Jul 2, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-botBot merged commit 22a990c into operator-framework:mainJul 2, 2025
@tmshort
tmshort deleted the more-features branch July 2, 2025 13:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@bentitobentitoAwaiting requested review from bentito
@perdasilvaperdasilvaAwaiting requested review from perdasilva

Assignees

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmshort@camilamacedo86