Skip to content

🌱 Update additional cert-manager locations to v1.18.2 - #2071

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:update-cert-manager
Jul 3, 2025
Merged

🌱 Update additional cert-manager locations to v1.18.2#2071
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:update-cert-manager

Conversation

@tmshort

@tmshorttmshort commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

The go.mod version of cert-manager was updated to v1.18.2

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Update additional cert-manager locations to v1.18.2
25b37df
The go.mod version of cert-manager was updated to v1.18.2
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort requested a review from a team as a code ownerJuly 3, 2025 17:39
@netlify

netlifyBot commented Jul 3, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit25b37df
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6866c06e1d761a0008434093
😎 Deploy Previewhttps://deploy-preview-2071--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort

tmshort commented Jul 3, 2025

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
camilamacedo86
camilamacedo86 approved these changes Jul 3, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good catcher

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@openshift-ci

openshift-ciBot commented Jul 3, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

camilamacedo86
camilamacedo86 reviewed Jul 3, 2025
View reviewed changes
Comment thread.tilt-support
cert_manager_var = '__CERT_MANAGER__'
if os.getenv(cert_manager_var) != '1':
deploy_cert_manager(version="v1.15.3")
deploy_cert_manager(version="v1.18.2")

@camilamacedo86camilamacedo86Jul 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if it could read the value from the Makefile, so we do not forget to update it.
Anyway, it is a very small, nice-to-have, so I will not block this one due to it
We can improve in follow up always :-)

/lgtm

@openshift-merge-bot
openshift-merge-botBot merged commit 245fc52 into operator-framework:mainJul 3, 2025
@tmshort
tmshort deleted the update-cert-manager branch July 3, 2025 19:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@anik120anik120Awaiting requested review from anik120
@gallettilancegallettilanceAwaiting requested review from gallettilance

Assignees

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmshort@camilamacedo86