Skip to content

🌱 Use metadata to determine namespace in args - #2072

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:use-env
Jul 3, 2025
Merged

🌱 Use metadata to determine namespace in args#2072
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:use-env

Conversation

@tmshort

@tmshorttmshort commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Use an env to get the metadata.namespace, and then use a variable in the arguments to get the value. Avoids putting the namespace into the manifest.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerJuly 3, 2025 17:46
@netlify

netlifyBot commented Jul 3, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit305ad66
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6866c87582f091000938510d
😎 Deploy Previewhttps://deploy-preview-2072--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
openshift-ciBot requested review from dtfranz and grokspawnJuly 3, 2025 17:46
@codecov

codecovBot commented Jul 3, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.43%. Comparing base (5665a32) to head (305ad66).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2072 +/- ##
==========================================
- Coverage 73.34% 72.43% -0.91% 
==========================================
Files 77 77 Lines 7056 7056 ==========================================
- Hits 5175 5111 -64 - Misses 1541 1602 +61 - Partials 340 343 +3
FlagCoverage Δ
e2e45.03% <ø> (ø)
experimental-e2e?
unit58.27% <ø> (+0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Use metadata to determine namespace in args
305ad66
Use an env to get the metadata.namespace, and then use a variable
in the arguments to get the value. Avoids putting the namespace
into the manifest.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort

tmshort commented Jul 3, 2025

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
camilamacedo86
camilamacedo86 approved these changes Jul 3, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@openshift-ci

openshift-ciBot commented Jul 3, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
tmshort merged commit 14b3eda into operator-framework:mainJul 3, 2025
@tmshort
tmshort deleted the use-env branch July 3, 2025 19:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@dtfranzdtfranzAwaiting requested review from dtfranz
@grokspawngrokspawnAwaiting requested review from grokspawn

Assignees

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmshort@camilamacedo86