Skip to content

🌱 crd-generator annotation text: generated -> generator - #2074

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
joelanford:generator-annotation-name
Jul 3, 2025
Merged

🌱 crd-generator annotation text: generated -> generator#2074
tmshort merged 1 commit into
operator-framework:mainfrom
joelanford:generator-annotation-name

Conversation

@joelanford

Copy link
Copy Markdown
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford
joelanford requested a review from a team as a code ownerJuly 3, 2025 20:25
@netlify

netlifyBot commented Jul 3, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit89157ee
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6866e96489616b00082481ac
😎 Deploy Previewhttps://deploy-preview-2074--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@tmshort

Copy link
Copy Markdown
Contributor

Unit test is failing because the test data needs to be updated.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford
joelanfordforce-pushed the generator-annotation-name branch from 3403101 to 89157eeCompareJuly 3, 2025 20:34
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@codecov

codecovBot commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (14b3eda) to head (89157ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2074 +/- ##
==========================================
- Coverage 73.29% 73.24% -0.06% 
==========================================
Files 77 77 Lines 7056 7056 ==========================================
- Hits 5172 5168 -4 - Misses 1543 1546 +3 - Partials 341 342 +1 
FlagCoverage Δ
e2e44.98% <ø> (-0.05%)⬇️
experimental-e2e51.25% <ø> (-0.05%)⬇️
unit58.20% <ø> (-0.05%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
tmshort merged commit 3d3ffd5 into operator-framework:mainJul 3, 2025
@joelanford
joelanford deleted the generator-annotation-name branch August 15, 2025 16:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@joelanford@tmshort