Uh oh!
There was an error while loading. Please reload this page.
🐛 OCPBUGS-61213: webhook operator update - #2184
Merged
openshift-merge-bot[bot] merged 1 commit intoSep 8, 2025
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
perdasilvaforce-pushed
the
webhook-operator-update
branch
from
September 4, 2025 12:31
8a2559f to
335463fCompareperdasilva
marked this pull request as draft
September 4, 2025 12:31
perdasilvaforce-pushed
the
webhook-operator-update
branch
2 times, most recently
from
September 4, 2025 15:06
5dd744a to
ea84f60CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2184 +/- ##
==========================================
+ Coverage 72.73% 72.76% +0.02%
==========================================
Files 79 79 Lines 7391 7391 ==========================================
+ Hits 5376 5378 +2 + Misses 1667 1666 -1 + Partials 348 347 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perdasilva
marked this pull request as ready for review
September 4, 2025 15:30
perdasilvaforce-pushed
the
webhook-operator-update
branch
2 times, most recently
from
September 4, 2025 15:32
8af05db to
05e5d1cCompareperdasilvaforce-pushed
the
webhook-operator-update
branch
from
September 4, 2025 15:41
05e5d1c to
40b721fCompare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilvaforce-pushed
the
webhook-operator-update
branch
from
September 4, 2025 15:43
40b721f to
77b4d9cCompareperdasilva
commented
Sep 4, 2025
| - --webhook-cert-path=/tmp/k8s-webhook-server/serving-certs | ||
| command: | ||
| - /manager | ||
| image: quay.io/olmtest/webhook-operator:0.0.4 |
ContributorAuthor
There was a problem hiding this comment.
this is the real important bit
tmshort
commented
Sep 8, 2025
Contributor
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-botBot
merged commit Sep 8, 2025
68610d0
into
operator-framework:main
23 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to the kube-rbac-proxy deprecation the webhook-operator used for testing is breaking tests (downstream).
To mitigate this until we have a proper test-operator, I've recreated the project on my account (github.com/operator-framework/webhook-operator) and bumped it to the latest version of kubebuilder.
NOTE: this is just a mitigation. We really need an in-tree test-operator with webhook support to help drive these tests.
Reviewer Checklist