Skip to content

🌱 promote rukpak hash util to shared package, use in boxcutter applier - #2201

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
joelanford:fix-deep-hash-object
Sep 12, 2025
Merged

🌱 promote rukpak hash util to shared package, use in boxcutter applier#2201
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
joelanford:fix-deep-hash-object

Conversation

@joelanford

@joelanfordjoelanford commented Sep 9, 2025

Copy link
Copy Markdown
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford
joelanford requested a review from a team as a code ownerSeptember 9, 2025 01:18
@netlify

netlifyBot commented Sep 9, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit2e16ac7
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68c48d46b4db0e0008283efa
😎 Deploy Previewhttps://deploy-preview-2201--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joelanfordjoelanford mentioned this pull request Sep 9, 2025
Closed
4 tasks
@codecov

codecovBot commented Sep 9, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.17%. Comparing base (c73b6e0) to head (2e16ac7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2201 +/- ##
==========================================
+ Coverage 71.95% 72.17% +0.22% 
==========================================
Files 85 85 Lines 8436 8407 -29 ==========================================
- Hits 6070 6068 -2 + Misses 1959 1939 -20 + Partials 407 400 -7
FlagCoverage Δ
e2e39.16% <70.00%> (+0.10%)⬆️
experimental-e2e46.19% <90.00%> (+0.16%)⬆️
unit57.01% <70.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tmshort
tmshort reviewed Sep 11, 2025
View reviewed changes
Comment threadinternal/shared/util/hash/hash.go
encoder := json.NewEncoder(hasher)
if err := encoder.Encode(obj); err != nil {
return "", fmt.Errorf("couldn't encode object: %w", err)
panic(fmt.Sprintf("couldn't encode object: %v", err))

@tmshorttmshortSep 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want this to panic? Seems a bit excessive?

@joelanfordjoelanfordSep 11, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: thetechnick#11 (comment)

@thetechnick

thetechnick commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

/approve

perdasilva
perdasilva reviewed Sep 12, 2025
View reviewed changes
Comment threadinternal/operator-controller/applier/boxcutter_test.go
},
}
defaultDesiredHash := "705ada5296ab26f74d94bfa497295a0cbccdb140623bbe704a3506cd1dfba4eb"
defaultDesiredHash := "gvvp8nzq5sbila80hkiv69am8hdr7o68qkk8n084gdn"

@perdasilvaperdasilvaSep 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could the change in hash cause problems with existing installed content after upgrade?

@perdasilvaperdasilvaSep 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if the upgrade CI job passed, we're good...?

@perdasilva

perdasilva commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ciBot commented Sep 12, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, thetechnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2025
@joelanford@tmshort
promote rukpak hash util to shared package, use in boxcutter applier
2e16ac7
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@tmshort

tmshort commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

I rebased this to deal with go.mod/go.sum changes.
/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 4867f92 into operator-framework:mainSep 12, 2025
25 checks passed
@joelanford
joelanford deleted the fix-deep-hash-object branch September 16, 2025 17:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perdasilvaperdasilvaperdasilva left review comments
@tmshorttmshorttmshort left review comments
@dtfranzdtfranzAwaiting requested review from dtfranz
@grokspawngrokspawnAwaiting requested review from grokspawn

Assignees

@tmshorttmshort

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelanford@thetechnick@perdasilva@tmshort