Skip to content

✨ CER Previous Limit - #2204

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
dtfranz:boxcutter-revision-limit
Sep 12, 2025
Merged

✨ CER Previous Limit#2204
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
dtfranz:boxcutter-revision-limit

Conversation

@dtfranz

@dtfranzdtfranz commented Sep 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Sets a limit to the number of previous ClusterExtensionRevisions we keep in the cluster, and trims the list of previous revisions when creating new revisions to stay at the limit. The limit has been set to 5 for now. Any revisions beyond this limit will be removed from the cluster EDIT: unless they are active.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@dtfranz
dtfranz requested a review from a team as a code ownerSeptember 10, 2025 13:47
@netlify

netlifyBot commented Sep 10, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitb640387
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68c3ecb19a92a3000825c52f
😎 Deploy Previewhttps://deploy-preview-2204--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecovBot commented Sep 10, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.98%. Comparing base (1821160) to head (b640387).
⚠️ Report is 7 commits behind head on main.

Files with missing linesPatch %Lines
internal/operator-controller/applier/boxcutter.go76.19%3 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2204 +/- ##
==========================================
- Coverage 72.09% 71.98% -0.12% 
==========================================
Files 85 85 Lines 8401 8457 +56 ==========================================
+ Hits 6057 6088 +31 - Misses 1941 1961 +20 - Partials 403 408 +5
FlagCoverage Δ
e2e39.14% <0.00%> (-0.25%)⬇️
experimental-e2e46.08% <23.80%> (-0.07%)⬇️
unit56.84% <76.19%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

You may need to rebase to get past the upgrade-experimental-e2e failure.

@dtfranz
dtfranzforce-pushed the boxcutter-revision-limit branch from 0686423 to 33610faCompareSeptember 11, 2025 04:28
@dtfranz

dtfranz commented Sep 11, 2025

Copy link
Copy Markdown
ContributorAuthor

You may need to rebase to get past the upgrade-experimental-e2e failure.

Thanks! It's passing now.

@perdasilva

perdasilva commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ciBot commented Sep 11, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@tmshort

tmshort commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Should the title be s/CRE/CER/g?

@tmshorttmshort changed the title ✨ CRE Previous Limit✨ CER Previous LimitSep 11, 2025
@dtfranz
dtfranzforce-pushed the boxcutter-revision-limit branch 3 times, most recently from 331cc7c to 55ed73cCompareSeptember 12, 2025 08:05
perdasilva
perdasilva reviewed Sep 12, 2025
View reviewed changes
Comment threadinternal/operator-controller/applier/boxcutter.go

// setPreviousRevisions populates spec.previous of latestRevision, trimming the list of previous _archived_ revisions down to
// ClusterExtensionRevisionPreviousLimit or to the first _active_ revision and deletes trimmed revisions from the cluster
func (bc *Boxcutter) setPreviousRevisions(ctx context.Context, latestRevision *ocv1.ClusterExtensionRevision, revisionList []ocv1.ClusterExtensionRevision) error {

@perdasilvaperdasilvaSep 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we call out that we expect revisionList to be sorted by revision number?

@dtfranzdtfranzSep 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'll add a comment here!

@dtfranz
CRE Previous Limit
b640387
Sets a limit to the number of previous ClusterExtensionRevisions we keep in the cluster, and trims the list of previous revisions when creating new revisions to stay at the limit. The limit has been set to 5 for now. Any revisions beyond this limit will be removed from the cluster.
Signed-off-by: Daniel Franz <dfranz@redhat.com>
@dtfranz
dtfranzforce-pushed the boxcutter-revision-limit branch from 55ed73c to b640387CompareSeptember 12, 2025 09:49
@perdasilva

perdasilva commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 8c42457 into operator-framework:mainSep 12, 2025
23 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perdasilvaperdasilvaperdasilva left review comments
@anik120anik120Awaiting requested review from anik120
@thetechnickthetechnickAwaiting requested review from thetechnick

Assignees

@perdasilvaperdasilva

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dtfranz@tmshort@perdasilva