Uh oh!
There was an error while loading. Please reload this page.
✨ Add more probing to CER - #2210
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tmshort
commented
Sep 11, 2025
/approve |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2210 +/- ##
==========================================
- Coverage 72.12% 71.98% -0.14%
==========================================
Files 85 85 Lines 8441 8424 -17 ==========================================
- Hits 6088 6064 -24 - Misses 1948 1955 +7
Partials 405 405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| } | ||
| // Checks if the Type: "Available" Condition is "True". | ||
| availableConditionProbe = &probing.ConditionProbe{ // "Available" == "True" |
There was a problem hiding this comment.
Nit, this is used only in one place (i.e. only one other reference).
| // Checks if .status.updatedReplicas == .status.replicas. | ||
| // Works for StatefulSts, Deployments and ReplicaSets. | ||
| replicasUpdatedProbe = &probing.FieldsEqualProbe{ |
There was a problem hiding this comment.
Nit, this is used only in one place (i.e. only one other reference).
There was a problem hiding this comment.
But i's AND'd with one other probe, to make it easier to read.
tmshort
commented
Sep 12, 2025
/lgtm |
c73b6e0
into
operator-framework:mainUh oh!
There was an error while loading. Please reload this page.
Description
Add more probes to the objects controlled by the ClusterExtensionRevision API.
Reviewer Checklist