Uh oh!
There was an error while loading. Please reload this page.
🐛 OPRUN-4139: Use old and new pod selectors during kustomize-to-helm transition - #2214
Merged
openshift-merge-bot[bot] merged 1 commit intoSep 11, 2025
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2214 +/- ##
=======================================
Coverage 72.06% 72.06% =======================================
Files 85 85 Lines 8401 8401 =======================================
Hits 6054 6054 Misses 1943 1943 Partials 404 404
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Downstream e2es are failing because the old selectors are still being used.
tmshort
commented
Sep 11, 2025
ContributorAuthor
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
grokspawn
commented
Sep 11, 2025
Contributor
/lgtm |
openshift-merge-botBot
merged commit Sep 11, 2025
6e22e2b
into
operator-framework:main
24 checks passed
Uh oh!
There was an error while loading. Please reload this page.
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Sep 12, 2025
Until downstream is ready to use the "app.kubernetes.io/name" selector, continue to use the "control-plane" selector in the tests. Change the network-policies to use a "control-plane" selector (which is still on pods because the Deployment selector is immutable). This includes a revert of "Use old and new pod selectors during kustomize-to-helm transition" This reverts operator-framework#2214 This reverts commit 6e22e2b.
4 tasks
tmshort added a commit
to tmshort/operator-controller
that referenced
this pull request
Sep 12, 2025
Until downstream is ready to use the "app.kubernetes.io/name" selector, continue to use the "control-plane" selector in the tests. Change the network-policies to use a "control-plane" selector (which is still on pods because the Deployment selector is immutable). This includes a revert of "Use old and new pod selectors during kustomize-to-helm transition" This reverts operator-framework#2214 This reverts commit 6e22e2b.
openshift-merge-botBot
pushed a commit
that referenced
this pull request
Sep 12, 2025
) Until downstream is ready to use the "app.kubernetes.io/name" selector, continue to use the "control-plane" selector in the tests. Change the network-policies to use a "control-plane" selector (which is still on pods because the Deployment selector is immutable). This includes a revert of "Use old and new pod selectors during kustomize-to-helm transition" This reverts #2214 This reverts commit 6e22e2b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream e2es are failing because the old selectors are still being used.
Description
Reviewer Checklist