Skip to content

🐛 Revert "migrate containers libs to new mono-repo" - #2215

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:revert-2195
Sep 12, 2025
Merged

🐛 Revert "migrate containers libs to new mono-repo"#2215
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:revert-2195

Conversation

@tmshort

@tmshorttmshort commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

PR #2195 broke the downstream build.

It seems that when this is downstreamed, and subsequently vendored and built within a container build that it's not entire rid of containers/images, as operator-framework/operator-registry still uses it, so there's still an indirect reference to containers/images in go.mod.

Reverting this in the downstream PR fixes the downstream build.

This reverts commit febdb59.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Revert "migrate containers libs to new mono-repo"
b4828eb
This reverts PR2195
This reverts commit febdb59.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort requested a review from a team as a code ownerSeptember 12, 2025 02:18
@netlify

netlifyBot commented Sep 12, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitb4828eb
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68c38308cde25b0008b06d0b
😎 Deploy Previewhttps://deploy-preview-2215--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort

tmshort commented Sep 12, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

/hold

Alternatively, we can try to update operator-registry and pull that in ASAP, because this is blocking downstreaming.

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2025
@codecov

codecovBot commented Sep 12, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.06%. Comparing base (6e22e2b) to head (b4828eb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2215 +/- ##
=======================================
Coverage 72.06% 72.06% =======================================
Files 85 85 Lines 8401 8401 =======================================
Hits 6054 6054 Misses 1943 1943 Partials 404 404
FlagCoverage Δ
e2e39.39% <ø> (ø)
experimental-e2e46.11% <ø> (-0.04%)⬇️
unit56.83% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anik120

anik120 commented Sep 12, 2025

Copy link
Copy Markdown
Member

@tmshortoperator-framework/operator-registry#1799

@tmshort

tmshort commented Sep 12, 2025

Copy link
Copy Markdown
ContributorAuthor

/unhold

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2025
@tmshort

tmshort commented Sep 12, 2025

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ci

openshift-ciBot commented Sep 12, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2025
@grokspawn

grokspawn commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit d0c7c0c into operator-framework:mainSep 12, 2025
25 checks passed
@tmshort
tmshort deleted the revert-2195 branch September 12, 2025 16:00
anik120 added a commit to anik120/operator-controller that referenced this pull request Sep 15, 2025
@anik120
Revert "Revert "migrate containers libs to new mono repo"operator-fr…
660a5d3
…amework#2215"
new operator-registry.v1.59.0 release contains migration, which should
fix the issue that necessitated operator-framework#2215
@anik120anik120 mentioned this pull request Sep 15, 2025
Merged
4 tasks
anik120 added a commit to anik120/operator-controller that referenced this pull request Sep 15, 2025
@anik120
Revert "Revert "migrate containers libs to new mono repo""
03c0fcb
new operator-registry.v1.59.0 release contains migration, which should
fix the issue that necessitated operator-framework#2215
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86Awaiting requested review from camilamacedo86
@dtfranzdtfranzAwaiting requested review from dtfranz

Assignees

@grokspawngrokspawn

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@anik120@grokspawn