Skip to content

✨ OPRUN-4150: Relax webhook support preconditions - #2222

Merged
openshift-merge-bot[bot] merged 6 commits into
operator-framework:mainfrom
perdasilva:relax-webhook-preconds
Sep 19, 2025
Merged

✨ OPRUN-4150: Relax webhook support preconditions#2222
openshift-merge-bot[bot] merged 6 commits into
operator-framework:mainfrom
perdasilva:relax-webhook-preconds

Conversation

@perdasilva

@perdasilvaperdasilva commented Sep 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

In OLMv0, only bundles with conversion webhooks must only support AllNamespaces install mode. In the initial implementation of the v1 support, we temporarily extended this to all webhook types. This PR brings v1 inline with v0 webhook support.

The PR also adds the CheckConversionWebhookSupport to the validator (which should have been done originally, but seems to have slipped)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerSeptember 16, 2025 09:34
@netlify

netlifyBot commented Sep 16, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit362b58e
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68cbb979a7941800083b1e14
😎 Deploy Previewhttps://deploy-preview-2222--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@perdasilvaperdasilva changed the title ✨ OPRUN-4150: Relax webhook preconditions✨ OPRUN-4150: Relax webhook support preconditionsSep 16, 2025
@codecov

codecovBot commented Sep 16, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.22%. Comparing base (27b05e7) to head (362b58e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2222 +/- ##
==========================================
+ Coverage 72.17% 72.22% +0.04% 
==========================================
Files 85 85 Lines 8407 8422 +15 ==========================================
+ Hits 6068 6083 +15 
Misses 1939 1939 Partials 400 400
FlagCoverage Δ
e2e39.16% <12.50%> (+0.03%)⬆️
experimental-e2e46.32% <62.50%> (+0.17%)⬆️
unit57.08% <100.00%> (+0.07%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pedjak
pedjak reviewed Sep 16, 2025
View reviewed changes
Comment threadinternal/operator-controller/rukpak/render/registryv1/validators/validator.go
Comment threadinternal/operator-controller/rukpak/render/registryv1/validators/validator.go Outdated
Comment threadinternal/operator-controller/rukpak/render/registryv1/validators/validator.go Outdated
Per Goncalves da Silva
Relax webhook preconditions
8b72968
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
pedjak
pedjak reviewed Sep 16, 2025
View reviewed changes
Comment threadinternal/operator-controller/rukpak/render/registryv1/validators/validator.go Outdated
Per G. da Silva added 4 commits September 17, 2025 10:50
Per G. da Silva
Fix up WithInstallModeSupportFor to include all install modes
1399b50
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Per G. da Silva
Add CheckConversionWebhookSupport to validator
9e91356
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Per G. da Silva
Add check for install mode support
42f01b5
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Per Goncalves da Silva
Update error messages
a1a5a58
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
pedjak
pedjak reviewed Sep 17, 2025
View reviewed changes
Comment threadinternal/operator-controller/rukpak/render/registryv1/registryv1.go
pedjak
pedjak reviewed Sep 17, 2025
View reviewed changes
Comment threadinternal/operator-controller/rukpak/render/registryv1/validators/validator.go Outdated
Per Goncalves da Silva
Remove error sorting by webhook name
362b58e
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@tmshort

tmshort commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ciBot commented Sep 19, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 5478ac6 into operator-framework:mainSep 19, 2025
25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedjakpedjakpedjak approved these changes
@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@bentitobentitoAwaiting requested review from bentito
@joelanfordjoelanfordAwaiting requested review from joelanford

Assignees

@pedjakpedjak

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@perdasilva@tmshort@pedjak@camilamacedo86