Skip to content

✨ OPRUN-4151: Add webhook rule validation - #2226

Merged
openshift-merge-bot[bot] merged 3 commits into
operator-framework:mainfrom
perdasilva:webhook-rule-validation
Sep 19, 2025
Merged

✨ OPRUN-4151: Add webhook rule validation#2226
openshift-merge-bot[bot] merged 3 commits into
operator-framework:mainfrom
perdasilva:webhook-rule-validation

Conversation

@perdasilva

Copy link
Copy Markdown
Contributor

Description

I recently discovered another boundary for webhook support [link] around the api groups and resources defined in the rules.

This PR adds that check to the bundle validator.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerSeptember 17, 2025 14:36
@netlify

netlifyBot commented Sep 17, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitd42452a
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68cd0aebcbf5e100086d7885
😎 Deploy Previewhttps://deploy-preview-2226--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@perdasilvaperdasilva changed the title ✨ Add webhook rule validation✨ OPRUN-4151: Add webhook rule validationSep 17, 2025
@codecov

codecovBot commented Sep 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.07%. Comparing base (27b05e7) to head (d42452a).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2226 +/- ##
==========================================
- Coverage 72.17% 72.07% -0.11% 
==========================================
Files 85 85 Lines 8407 8423 +16 ==========================================
+ Hits 6068 6071 +3 - Misses 1939 1950 +11 - Partials 400 402 +2 
FlagCoverage Δ
e2e39.08% <16.66%> (-0.05%)⬇️
experimental-e2e46.06% <55.55%> (-0.09%)⬇️
unit57.06% <88.88%> (+0.05%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva

Copy link
Copy Markdown
ContributorAuthor

Oh, whoops, I need to sub out the olmv0 api group with the olmv1 one

@perdasilva
perdasilvaforce-pushed the webhook-rule-validation branch from 77e4d47 to 5ac96d1CompareSeptember 17, 2025 15:00
@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@perdasilva
perdasilvaforce-pushed the webhook-rule-validation branch from 5ac96d1 to 08d46c3CompareSeptember 18, 2025 12:17
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilvaforce-pushed the webhook-rule-validation branch from f51aaea to 35a98fcCompareSeptember 18, 2025 15:15
Per Goncalves da Silva added 2 commits September 19, 2025 09:48
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilvaforce-pushed the webhook-rule-validation branch from 35a98fc to d42452aCompareSeptember 19, 2025 07:48
@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit d3e8883 into operator-framework:mainSep 19, 2025
25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@perdasilva@tmshort@pedjak@camilamacedo86