Skip to content

🌱 OPRUN-4138 Make ClusterExtensionRevision.spec.phases optional - #2230

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:cer-phases-optional
Sep 22, 2025
Merged

🌱 OPRUN-4138 Make ClusterExtensionRevision.spec.phases optional#2230
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:cer-phases-optional

Conversation

@pedjak

@pedjakpedjak commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

Description

Given that at the creation we can create a revision with no phases, we should
declare .spec.phases as optional.

Added initial set of unit tests to assert CER .spec immutability.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@pedjak
Make ClusterExtensionRevision.spec.phases optional
a77e58f
Given that at the creation we can create a revision with no phases, we should
declare `.spec.phases` as optional.
Added initial set of unit tests to assert CER .spec immutability.
@pedjak
pedjak requested a review from a team as a code ownerSeptember 22, 2025 15:22
@netlify

netlifyBot commented Sep 22, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commita77e58f
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68d1699d3a42900008d71d22
😎 Deploy Previewhttps://deploy-preview-2230--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pedjakpedjak changed the title 🌱 Make ClusterExtensionRevision.spec.phases optional🌱 OPRUN-4138 Make ClusterExtensionRevision.spec.phases optionalSep 22, 2025
@codecov

codecovBot commented Sep 22, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.28%. Comparing base (33fdce2) to head (a77e58f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2230 +/- ##
==========================================
+ Coverage 72.05% 72.28% +0.23% 
==========================================
Files 85 85 Lines 8405 8440 +35 ==========================================
+ Hits 6056 6101 +45 + Misses 1948 1939 -9 + Partials 401 400 -1
FlagCoverage Δ
e2e39.07% <ø> (-0.11%)⬇️
experimental-e2e46.30% <ø> (+0.22%)⬆️
unit57.15% <ø> (+0.15%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
@openshift-ci

openshift-ciBot commented Sep 22, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 16d1089 into operator-framework:mainSep 22, 2025
26 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86Awaiting requested review from camilamacedo86
@dtfranzdtfranzAwaiting requested review from dtfranz

Assignees

@tmshorttmshort

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pedjak@tmshort