Skip to content

🌱 OPRUN-4138 Load CRDs for envtests from chart directory - #2232

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:fix-crd-load-path-unit-tests
Sep 23, 2025
Merged

🌱 OPRUN-4138 Load CRDs for envtests from chart directory#2232
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:fix-crd-load-path-unit-tests

Conversation

@pedjak

Copy link
Copy Markdown
Contributor

Description

Followup of #2145: given that config folder is going to be removed soon,
internal/operator-controller/controllers/suite_test.go loads CRDs from
helm/olmv1/base/operator-controller/crd.

Creation of envtest.Environment moved and consolidated into test/utils.go
so that it can be consumed by multiple test suites.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Followup of operator-framework#2145: given that `config` folder is going to be removed soon,
`internal/operator-controller/controllers/suite_test.go` loads CRDs from
`helm/olmv1/base/operator-controller/crd`.
Creation of `envtest.Environment` moved and consolidated into `test/utils.go`
so that it can be consumed by multiple test suites.
@pedjak
pedjak requested a review from a team as a code ownerSeptember 23, 2025 14:41
@netlify

netlifyBot commented Sep 23, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitf1c67b9
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68d2b19037ac980008930ab6
😎 Deploy Previewhttps://deploy-preview-2232--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecovBot commented Sep 23, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.84%. Comparing base (16d1089) to head (f1c67b9).
⚠️ Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
test/utils.go0.00%34 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2232 +/- ##
==========================================
- Coverage 72.16% 71.84% -0.33% 
==========================================
Files 85 86 +1 Lines 8440 8474 +34 ==========================================
- Hits 6091 6088 -3 - Misses 1948 1984 +36 - Partials 401 402 +1 
FlagCoverage Δ
e2e39.11% <ø> (ø)
experimental-e2e46.17% <ø> (ø)
unit56.92% <0.00%> (-0.23%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 47f8d31 into operator-framework:mainSep 23, 2025
25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pedjak@tmshort