Skip to content

🌱 OPRUN-4138 Remove bingo-upgrade Makefile target - #2234

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:remove-bingo-upgrade
Sep 24, 2025
Merged

🌱 OPRUN-4138 Remove bingo-upgrade Makefile target#2234
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:remove-bingo-upgrade

Conversation

@pedjak

Copy link
Copy Markdown
Contributor

Description

It is not referred in any of CI workflows, nor documented in the contribution guide.
Also, its usage is questionable given that it tries to upgrade all tools to the latest version at once.
Typically such upgrades are performed in a more controlled way, one PR per tool, either by developer
or dependbot.

Developers are still able to initiate an update by invoking

bingo get foo@x.y.z

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

It is not referred in any of CI workflows, nor documented in the contribution guide.
Also, its usage is questionable given that it tries to upgrade all tools to the latest version at once.
Typically such upgrades are performed in a more controlled way, one PR per tool, either by developer
or dependbot.
Developers are still able to initiate an update by invoking
```
bingo get foo@x.y.z
```
@pedjak
pedjak requested a review from a team as a code ownerSeptember 24, 2025 17:48
@netlify

netlifyBot commented Sep 24, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commite327a6a
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68d42ef57a27c9000801e2bb
😎 Deploy Previewhttps://deploy-preview-2234--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pedjakpedjak changed the title 🌱 Remove bingo-upgrade Makefile target🌱 OPRUN-4138 Remove bingo-upgrade Makefile targetSep 24, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
@codecov

codecovBot commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.87%. Comparing base (0faf118) to head (e327a6a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2234 +/- ##
==========================================
+ Coverage 71.84% 71.87% +0.03% 
==========================================
Files 86 86 Lines 8474 8474 ==========================================
+ Hits 6088 6091 +3 + Misses 1984 1982 -2 + Partials 402 401 -1 
FlagCoverage Δ
e2e39.07% <ø> (-0.08%)⬇️
experimental-e2e46.17% <ø> (ø)
unit56.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot
openshift-merge-botBot merged commit 102383e into operator-framework:mainSep 24, 2025
25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pedjak@tmshort