Skip to content

🐛 OPRUN-4166: Use long name for curl image - #2235

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:use-long-name
Sep 25, 2025
Merged

🐛 OPRUN-4166: Use long name for curl image#2235
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:use-long-name

Conversation

@tmshort

@tmshorttmshort commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

The short name was causing downstream issues:

image name curlimages/curl:8.15.0 returns ambiguous list

Using the long name seems to fix this.

Already tested downstream.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerSeptember 25, 2025 03:32
@netlify

netlifyBot commented Sep 25, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit2b97b47
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68d4bcad466f9b00085846ab
😎 Deploy Previewhttps://deploy-preview-2235--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jianzhangbjz

jianzhangbjz commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@tmshort
Use long name for curl image
2b97b47
The short name was causing downstream issues:
```
image name curlimages/curl:8.15.0 returns ambiguous list
```
Using the long name seems to fix this.
Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@tmshort

tmshort commented Sep 25, 2025

Copy link
Copy Markdown
ContributorAuthor

/approve

@openshift-ci

openshift-ciBot commented Sep 25, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@dtfranz

dtfranz commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@codecov

codecovBot commented Sep 25, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.84%. Comparing base (0faf118) to head (2b97b47).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2235 +/- ##
=======================================
Coverage 71.84% 71.84% =======================================
Files 86 86 Lines 8474 8474 =======================================
Hits 6088 6088 Misses 1984 1984 Partials 402 402
FlagCoverage Δ
e2e39.07% <ø> (-0.08%)⬇️
experimental-e2e46.17% <ø> (ø)
unit56.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot
openshift-merge-botBot merged commit 55d9dfb into operator-framework:mainSep 25, 2025
24 checks passed
@jianzhangbjzjianzhangbjz mentioned this pull request Sep 25, 2025
Closed
@tmshorttmshort changed the title 🐛 Use long name for curl image🐛 OPRUN-4166: Use long name for curl imageSep 25, 2025
@tmshort
tmshort deleted the use-long-name branch September 25, 2025 13:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtfranzdtfranzAwaiting requested review from dtfranz
@rashmigottipatirashmigottipatiAwaiting requested review from rashmigottipati

Assignees

@dtfranzdtfranz

@jianzhangbjzjianzhangbjz

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@jianzhangbjz@dtfranz