Skip to content

🌱 Refactor NewBundleFS test utility to builder pattern - #2237

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:refactor-new-bundle-fs
Oct 2, 2025
Merged

🌱 Refactor NewBundleFS test utility to builder pattern#2237
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:refactor-new-bundle-fs

Conversation

@perdasilva

@perdasilvaperdasilva commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Description

While doing some refactoring work to fix a bug, it became clear I'd need better test tooling to create test bundle filesystems. This PR updates the NewBundleFS utility using the builder pattern to help compose a valid registry+v1 bundle FS for testing

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerSeptember 26, 2025 15:52
@netlify

netlifyBot commented Sep 26, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit1ccac24
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68dd4fb9c0f1a30008dc8d6b
😎 Deploy Previewhttps://deploy-preview-2237--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecovBot commented Sep 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.62500% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.61%. Comparing base (55d9dfb) to head (1ccac24).
⚠️ Report is 7 commits behind head on main.

Files with missing linesPatch %Lines
...ontroller/rukpak/util/testing/bundlefs/bundlefs.go90.47%3 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2237 +/- ##
==========================================
+ Coverage 71.87% 72.61% +0.73% 
==========================================
Files 86 86 Lines 8474 8592 +118 ==========================================
+ Hits 6091 6239 +148 + Misses 1982 1943 -39 - Partials 401 410 +9 
FlagCoverage Δ
e2e38.58% <0.00%> (-0.53%)⬇️
experimental-e2e45.73% <0.00%> (-0.49%)⬇️
unit57.77% <90.62%> (+0.84%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment threadinternal/operator-controller/applier/boxcutter_test.go Outdated
@perdasilva
perdasilvaforce-pushed the refactor-new-bundle-fs branch 3 times, most recently from ffc7bfa to f187d48CompareOctober 1, 2025 15:46
@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilvaforce-pushed the refactor-new-bundle-fs branch from f187d48 to 1ccac24CompareOctober 1, 2025 15:58
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@pedjak

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@perdasilvaperdasilva changed the title 🌱 Update NewBundleFS test utility🌱 Refactor NewBundleFS test utility to builder patternOct 2, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, thetechnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 5f37a67 into operator-framework:mainOct 2, 2025
30 of 31 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@perdasilva@pedjak@thetechnick