Skip to content

🐛 OCPBUGS-62021: Fix install mode support gating - #2238

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:singlens-bug-fix
Oct 2, 2025
Merged

🐛 OCPBUGS-62021: Fix install mode support gating#2238
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
perdasilva:singlens-bug-fix

Conversation

@perdasilva

@perdasilvaperdasilva commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Description

The RegistryV1HelmChartProvider was letting through bundles that don't support AllNamespaces mode.

RegistryV1HelmChartProvider is updated to handle the SingleOwnNamespace feature in the same way the Webhook feature is handled. In a follow-up PR, GetWatchNamespace() (which checks for the SingleOwnNamespace feature) will be moved into this component.

Note: This PR used to have an e2e tests to ensure bundles not supported by the standard OLMv1 profile get rejected. But, there's currently no way to execute an e2e test on the standard profile only. So, I've removed it and will add in a follow up PR once we've addressed this the right way.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerSeptember 26, 2025 17:30
@netlify

netlifyBot commented Sep 26, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit076a509
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68dd437e3db9790008394d15
😎 Deploy Previewhttps://deploy-preview-2238--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort

Copy link
Copy Markdown
Contributor

The experimental-e2e is not passing...
But I'll run them again (one was a timeout condition)

@perdasilvaperdasilva changed the title 🐛 Fix install mode support gating🐛 OCPBUGS-62021: Fix install mode support gatingSep 29, 2025
@perdasilva

Copy link
Copy Markdown
ContributorAuthor

The experimental-e2e is not passing... But I'll run them again (one was a timeout condition)

Yeah - these aren't really meant to be run in experimental mode. It's to check that the things that are enabled in experimental mode aren't enabled out of experimental mode

Comment threadinternal/operator-controller/applier/provider.go Outdated
Comment threadinternal/operator-controller/applier/provider.go
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@codecov

codecovBot commented Oct 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.15%. Comparing base (55d9dfb) to head (076a509).
⚠️ Report is 8 commits behind head on main.

Files with missing linesPatch %Lines
internal/operator-controller/applier/provider.go76.92%4 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2238 +/- ##
==========================================
+ Coverage 71.87% 72.15% +0.27% 
==========================================
Files 86 86 Lines 8474 8590 +116 ==========================================
+ Hits 6091 6198 +107 - Misses 1982 1984 +2 - Partials 401 408 +7 
FlagCoverage Δ
e2e38.68% <63.33%> (-0.43%)⬇️
experimental-e2e45.61% <0.00%> (-0.60%)⬇️
unit57.27% <66.66%> (+0.34%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, pedjak, thetechnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit fbd2e65 into operator-framework:mainOct 2, 2025
25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@perdasilva@tmshort@pedjak@thetechnick@grokspawn