🌱 Deduplicate component generating registry+v1 manifests in appliers

[perdasilva]

Description

Currently, both the helm and boxcutter appliers implement different components doing the same thing: producing manifests from registry+v1 bundles and configuration.

This PR removes that duplication by unifying it the RegistryV1ManifestProvider, which wraps the registry+v1 renderer configuring it appropriately and also checks the bundle for olmv1 support. It also removes the GetWatchNamespace function incorporating it into the RegistryV1ManifestProvider.

With this PR, both applier implementations will be using the exact same component to generate the desired manifests from the (registry+v1) bundle and the configuration given through the ClusterExtension API.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	378a3f6
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/68e4c921fcc27d00085a2e2b
😎 Deploy Preview	https://deploy-preview-2251--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

❌ Patch coverage is 75.92593% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.90%. Comparing base (35da385) to head (378a3f6).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/operator-controller/main.go	61.11%	4 Missing and 3 partials ⚠️
internal/operator-controller/applier/provider.go	82.35%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #2251 +/- ##
==========================================
+ Coverage 72.50% 72.90% +0.40% 
==========================================
Files 87 88 +1 Lines 8593 8733 +140 ==========================================
+ Hits 6230 6367 +137 - Misses 1951 1953 +2 - Partials 412 413 +1 

Flag	Coverage Δ
e2e	39.29% <40.74%> (+0.55%)	⬆️
experimental-e2e	46.27% <50.00%> (+0.76%)	⬆️
unit	57.99% <55.55%> (+0.19%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[camilamacedo86]

It seems reasonable.. Justa refactory
I could not spot anything here that could block this one.

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, thetechnick, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• cmd/OWNERS [tmshort]
• internal/operator-controller/OWNERS [thetechnick,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment