Skip to content

🌱 fix: make hack/tools/update-tls-profiles.sh work on macOS - #2256

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
joelanford:update-tls-profiles-macos
Oct 7, 2025
Merged

🌱 fix: make hack/tools/update-tls-profiles.sh work on macOS#2256
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
joelanford:update-tls-profiles-macos

Conversation

@joelanford

Copy link
Copy Markdown
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford
joelanford requested a review from a team as a code ownerOctober 7, 2025 17:19
@netlify

netlifyBot commented Oct 7, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitb6d803f
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68e54baeb7d9550007154650
😎 Deploy Previewhttps://deploy-preview-2256--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@tmshort

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecovBot commented Oct 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.69%. Comparing base (029484d) to head (b6d803f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2256 +/- ##
==========================================
+ Coverage 70.35% 72.69% +2.34% 
==========================================
Files 89 89 Lines 8747 8747 ==========================================
+ Hits 6154 6359 +205 + Misses 2207 1970 -237 - Partials 386 418 +32 
FlagCoverage Δ
e2e39.19% <ø> (?)
experimental-e2e45.84% <ø> (-0.17%)⬇️
unit57.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot
openshift-merge-botBot merged commit 6604f2a into operator-framework:mainOct 7, 2025
28 of 29 checks passed
@joelanford
joelanford deleted the update-tls-profiles-macos branch December 5, 2025 15:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joelanford@tmshort@camilamacedo86@grokspawn