Skip to content

🐛 add rollingUpdate strategy - #2263

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
jianzhangbjz:bug-62517
Oct 13, 2025
Merged

🐛 add rollingUpdate strategy#2263
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
jianzhangbjz:bug-62517

Conversation

@jianzhangbjz

Copy link
Copy Markdown
Contributor

Description

To address the issue: the cluster operator olm Available=False when cluster upgrading.
I have tested this solution in openshift/operator-framework-operator-controller#515, and it works.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@jianzhangbjz
jianzhangbjz requested a review from a team as a code ownerOctober 13, 2025 01:14
@netlify

netlifyBot commented Oct 13, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit9e5978e
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68ec6010f194da0008fbe026
😎 Deploy Previewhttps://deploy-preview-2263--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jianzhangbjz

jianzhangbjz commented Oct 13, 2025

Copy link
Copy Markdown
ContributorAuthor

https://github.com/operator-framework/operator-controller/actions/runs/18452353047/job/52567797659?pr=2263 failed at:

 cluster_extension_install_test.go:1052: ByeventuallyreportingProgressing==TruewithReasonRetrying
cluster_extension_install_test.go:1053: ErrorTrace:	/home/runner/work/operator-controller/operator-controller/test/e2e/cluster_extension_install_test.go:1058/opt/hostedtoolcache/go/1.24.4/x64/src/runtime/asm_amd64.s:1700
Error: Not equal: expected: "Retrying"
actual : "RolloutInProgress"
Diff:
---Expected+++Actual
@@ -1+1 @@
-Retrying+RolloutInProgress
cluster_extension_install_test.go:1053: ErrorTrace:	/home/runner/work/operator-controller/operator-controller/test/e2e/cluster_extension_install_test.go:1053
Error: Conditionneversatisfied
Test: TestClusterExtensionRecoversFromExistingDeploymentWhenFailureFixed

Signed-off-by: Jian Zhang <jiazha@redhat.com>
@codecov

codecovBot commented Oct 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (95c5934) to head (9e5978e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2263 +/- ##
=======================================
Coverage 72.87% 72.87% =======================================
Files 88 88 Lines 8733 8733 =======================================
Hits 6364 6364 Misses 1955 1955 Partials 414 414 
FlagCoverage Δ
e2e39.29% <ø> (+0.03%)⬆️
experimental-e2e46.31% <ø> (ø)
unit57.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@tmshort

Copy link
Copy Markdown
Contributor

https://github.com/operator-framework/operator-controller/actions/runs/18452353047/job/52567797659?pr=2263 failed at...
@jianzhangbjz this is an uncommon flake... to the point we usually just run the test again and it passes.

@openshift-merge-bot
openshift-merge-botBot merged commit 687401c into operator-framework:mainOct 13, 2025
24 checks passed
@openshift-merge-robot

Copy link
Copy Markdown

Fix included in accepted release 4.21.0-0.nightly-2025-10-15-101012

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jianzhangbjz@tmshort@openshift-merge-robot