Skip to content

🌱 OPRUN-4194: Allow openshift catalog versions to be configurable via helm - #2264

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:updatable-catalog-versions
Oct 13, 2025
Merged

🌱 OPRUN-4194: Allow openshift catalog versions to be configurable via helm#2264
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:updatable-catalog-versions

Conversation

@tmshort

@tmshorttmshort commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerOctober 13, 2025 13:46
@netlify

netlifyBot commented Oct 13, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitd5c0eb7
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68ed0afc297cf50008f7e742
😎 Deploy Previewhttps://deploy-preview-2264--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshorttmshort mentioned this pull request Oct 13, 2025
Closed
@openshift-ciopenshift-ciBot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2025
@camilamacedo86

camilamacedo86 commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

/lgtm

pedjak
pedjak reviewed Oct 13, 2025
View reviewed changes
Comment threadhelm/olmv1/values.yaml Outdated
enabled: false
# This can be one of: standard or experimental
featureSet: standard
catalogVersion: v4.20

@pedjakpedjakOct 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about to make a struct like this:

catalog:
version: v4.20

it opens up a room for future extension without having long descriptive variable names?

@tmshorttmshortOct 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did ponder that...

@tmshort

tmshort commented Oct 13, 2025

Copy link
Copy Markdown
ContributorAuthor

/hold

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@tmshort
Allow openshift catalog versions to be configurable via helm
d5c0eb7
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshortforce-pushed the updatable-catalog-versions branch from 8cebfa4 to d5c0eb7CompareOctober 13, 2025 14:21
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@tmshort

tmshort commented Oct 13, 2025

Copy link
Copy Markdown
ContributorAuthor

/unhold
Ok, I actually put it under the openshift option, because it is openshift specific.

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
pedjak
pedjak reviewed Oct 13, 2025
View reviewed changes
Comment threadhelm/olmv1/values.yaml
enabled: false
openshift:
enabled: false
catalogs:

@pedjakpedjakOct 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have mutiple catalogs with the same version or it should be

catalog:
version: v4.20

@tmshorttmshortOct 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought of this... and it doesn't matter too much.
I put it under openshift.

camilamacedo86
camilamacedo86 approved these changes Oct 13, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci

openshift-ciBot commented Oct 13, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecovBot commented Oct 13, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.06%. Comparing base (6604f2a) to head (d5c0eb7).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2264 +/- ##
==========================================
+ Coverage 72.73% 73.06% +0.32% 
==========================================
Files 89 88 -1 Lines 8747 8738 -9 ==========================================
+ Hits 6362 6384 +22 + Misses 1968 1942 -26 + Partials 417 412 -5
FlagCoverage Δ
e2e39.44% <ø> (+0.24%)⬆️
experimental-e2e46.83% <ø> (+0.96%)⬆️
unit58.01% <ø> (+0.04%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot
openshift-merge-botBot merged commit 48d5ccd into operator-framework:mainOct 13, 2025
32 of 34 checks passed
@tmshort
tmshort deleted the updatable-catalog-versions branch October 13, 2025 15:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedjakpedjakpedjak approved these changes
@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@oceanc80oceanc80Awaiting requested review from oceanc80
@OchiengEdOchiengEdAwaiting requested review from OchiengEd

Assignees

@pedjakpedjak

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@camilamacedo86@pedjak