Skip to content

🐛 Remove creationTimestamp and status fields from webhook-operator test resources - #2295

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:fix-webook-operator-resources
Oct 31, 2025
Merged

🐛 Remove creationTimestamp and status fields from webhook-operator test resources#2295
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:fix-webook-operator-resources

Conversation

@pedjak

Copy link
Copy Markdown
Contributor

Description

Its presence has forced the BoxCutter applier to believe that resources differ from
those existing on the cluster and thus new revisions are created indefinitely on each reconcile
when trying to install webhook-operator package.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

…st resources
It presence has forced the BoxCutter applier to believe that resources differ from
those existing on the cluster and thus new revisions are created indefinitely on each reconcile
when trying to install webhook-operator package.
CopilotAI review requested due to automatic review settings October 31, 2025 17:51
@pedjak
pedjak requested a review from a team as a code ownerOctober 31, 2025 17:51
@netlify

netlifyBot commented Oct 31, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit1081521
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6904f734f206ed00089dfc1d
😎 Deploy Previewhttps://deploy-preview-2295--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pedjakpedjak changed the title Remove creationTimestamp and status fields from webhook-operator test resources🐛 Remove creationTimestamp and status fields from webhook-operator test resourcesOct 31, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up Kubernetes manifest files by removing auto-generated and runtime fields that should not be committed to source control. These fields (creationTimestamp, empty status sections, and null spec values) are typically populated by Kubernetes at runtime.

  • Removed creationTimestamp: null from CRD and ClusterRole metadata
  • Removed empty status section from CustomResourceDefinition
  • Removed "spec": null entries from ClusterServiceVersion example manifests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
webhook.operators.coreos.io_webhooktests.yamlRemoved creationTimestamp field from metadata and empty status section from CRD definition
webhook-operator.clusterserviceversion.yamlRemoved "spec": null entries from example resource definitions for v1 and v2 API versions
webhook-operator-metrics-reader_rbac.authorization.k8s.io_v1beta1_clusterrole.yamlRemoved creationTimestamp field from ClusterRole metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecovBot commented Oct 31, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.38%. Comparing base (8bda126) to head (1081521).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2295 +/- ##
==========================================
+ Coverage 71.28% 74.38% +3.09% 
==========================================
Files 90 90 Lines 7003 7003 ==========================================
+ Hits 4992 5209 +217 + Misses 1599 1385 -214 + Partials 412 409 -3 
FlagCoverage Δ
e2e45.85% <ø> (-0.04%)⬇️
experimental-e2e48.23% <ø> (+33.63%)⬆️
unit58.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rashmigottipatirashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 1572d1c into operator-framework:mainOct 31, 2025
30 of 32 checks passed
@dtfranzdtfranz mentioned this pull request Nov 11, 2025
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pedjak@perdasilva@rashmigottipati