Skip to content

✨ OPRUN-4240: Add Claude Code integration for test profiling - #2309

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:claude-memory-profiling
Nov 18, 2025
Merged

✨ OPRUN-4240: Add Claude Code integration for test profiling#2309
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:claude-memory-profiling

Conversation

@tmshort

@tmshorttmshort commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Add /test-profile slash command to enable interactive profiling workflow through Claude Code interface.

Follow-on to #2298

🤖 Generated with Claude Code

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerNovember 5, 2025 18:45
@netlify

netlifyBot commented Nov 5, 2025

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitfb21aa5
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6914d5107322460008fec9a5
😎 Deploy Previewhttps://deploy-preview-2309--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecovBot commented Nov 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.26%. Comparing base (d204888) to head (fb21aa5).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2309 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16% 
==========================================
Files 91 91 Lines 7057 7057 ==========================================
- Hits 5252 5241 -11 - Misses 1393 1402 +9 - Partials 412 414 +2 
FlagCoverage Δ
e2e45.83% <ø> (-0.04%)⬇️
experimental-e2e48.23% <ø> (-0.22%)⬇️
unit58.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we should discuss before merging.
Personally, I’d prefer that we keep our instructions AI-agnostic, rather than tied to a specific vendor or model like Claude.

For example, instead of adding a CLAUDE.md, we could introduce something like an AGENTS.md file that describes generic AI/agent usage and workflows. Then, if needed, we could create aliases or vendor-specific adapters for Claude, ChatGPT, etc. — without locking ourselves to one ecosystem.

Also, just to confirm: can every contributor actually use Claude?
Do all contributors have access to it without a paid plan?
If not, that might make a vendor-specific setup harder to maintain or may exclude contributors unintentionally.

@tmshort

Copy link
Copy Markdown
ContributorAuthor

/hold

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion: https://kubernetes.slack.com/archives/C04066HP28K/p1762846782356659?thread_ts=1762534450.554899&cid=C04066HP28K

I think we can move forward and after we see if we can make it work with others AI toolings as well.

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@tmshort
tmshortforce-pushed the claude-memory-profiling branch from d2ae505 to d58e2d1CompareNovember 11, 2025 14:21
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@tmshort

Copy link
Copy Markdown
ContributorAuthor

/unhold
Based on the slack thread.
I have also updated this to be more precise. @camilamacedo86

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2025
@tmshorttmshort changed the title ✨ OPRUN-4240: Add Claude Code integration for e2e profiling✨ OPRUN-4240: Add Claude Code integration for test profilingNov 11, 2025
Comment thread.claude/commands/test-profile.md Outdated

- kubectl access to cluster
- go tool pprof (for analysis)
- Go 1.22+ (for building)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmshort ^ is that true
How will we keep it updated?
Should not minimal go requirement same of go.mod ?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to be a reference to the appropriate go.mod

Add `/test-profile` slash command to enable interactive profiling workflow
through Claude Code interface with the Go-based test profiling tools.
The command provides access to:
- start/stop: Background profiling daemon workflow
- run: Automated test execution with profiling
- analyze: Generate analysis reports from collected profiles
- compare: Compare two test runs side-by-side
- collect: One-time profile snapshots
Documentation includes configuration, output structure, and implementation
steps for the Go-based CLI tool located in hack/tools/test-profiling/.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshortforce-pushed the claude-memory-profiling branch from d58e2d1 to fb21aa5CompareNovember 12, 2025 18:42
@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
@camilamacedo86

Copy link
Copy Markdown
Contributor

Great 👍
I think it is fine we can improve in the long run as well.

It is amazing see our first command instruction 🎉
Well done.

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit be247a9 into operator-framework:mainNov 18, 2025
24 checks passed
@tmshort
tmshort deleted the claude-memory-profiling branch November 18, 2025 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@camilamacedo86@perdasilva