Skip to content

🐛 Restore ManagedFields to operator-controller cache - #2318

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:memory-improvements
Nov 11, 2025
Merged

🐛 Restore ManagedFields to operator-controller cache#2318
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:memory-improvements

Conversation

@tmshort

@tmshorttmshort commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

The Boxcutter library uses ManagedFields internally, so we need to keep them around, at least in operator-controller. Catalogd can still strip them from its cache.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Restore ManagedFields to operator-controller cache
6b927e9
The Boxcutter library uses ManagedFields internally, so we need to keep them
around, at least in operator-controller. Catalogd can still strip them from
its cache.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort requested a review from a team as a code ownerNovember 10, 2025 20:46
@netlify

netlifyBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit6b927e9
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/69124f10eb4cdc0008c955e6
😎 Deploy Previewhttps://deploy-preview-2318--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@perdasilva

perdasilva commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ciBot commented Nov 11, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@codecov

codecovBot commented Nov 11, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.26%. Comparing base (b3f85d5) to head (6b927e9).
⚠️ Report is 6 commits behind head on main.

Files with missing linesPatch %Lines
internal/operator-controller/applier/boxcutter.go50.00%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #2318 +/- ##
==========================================
+ Coverage 71.14% 74.26% +3.11% 
==========================================
Files 91 91 Lines 7046 7057 +11 ==========================================
+ Hits 5013 5241 +228 + Misses 1618 1402 -216 + Partials 415 414 -1
FlagCoverage Δ
e2e45.89% <50.00%> (-0.05%)⬇️
experimental-e2e48.25% <75.00%> (?)
unit58.50% <12.50%> (-0.08%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

oceanc80
oceanc80 reviewed Nov 11, 2025
View reviewed changes

@oceanc80oceanc80 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 6beca87 into operator-framework:mainNov 11, 2025
25 checks passed
@tmshort
tmshort deleted the memory-improvements branch November 11, 2025 13:53
@pedjakpedjak mentioned this pull request Nov 17, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oceanc80oceanc80oceanc80 left review comments
@anik120anik120Awaiting requested review from anik120
@perdasilvaperdasilvaAwaiting requested review from perdasilva
@joelanfordjoelanfordAwaiting requested review from joelanford

Assignees

@oceanc80oceanc80

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmshort@perdasilva@oceanc80